Open Stack

I released django_openstack_auth 1.1.6 on Friday to fix the login issue
with PKIZ.  Part of that release contained a pep8 cleanup that broke
Horizon, ultimately because we were doing something stupid in Horizon.  We
added a fix to Horizon to correct the issue on trunk
https://github.com/openstack/horizon/commit/0bd4350cb308d57b6afc69daee4a782
3055be5a9.  However, to allow older versions of Horizon to work with newer
django_openstack_auth versions, I currently have a patch up to restore the
strange import in openstack_auth  https://review.openstack.org/#/c/101715/
once that merges I will release django_openstack_auth 1.1.7 and all gates
should work again.

David


From:  Morgan Fainberg <morgan.fainberg at gmail.com>
Reply-To:  OpenStack List <openstack-dev at lists.openstack.org>
Date:  Saturday, June 21, 2014 at 12:27 PM
To:  OpenStack List <openstack-dev at lists.openstack.org>
Subject:  Re: [openstack-dev] horizon failing on icehouse 100%, currently
blocking all patches


The issue with the login page simply refreshing was due to a change in
Keystone that updated the type of Token issued by default from PKI to PKIZ
(compressed PKI/ASN1). The update to the django auth module was intended
to correct that specific
 issue with Keystone and Horizon (Juno).

The bug fix (not sure if another review is to blame with the
django_openstack_auth module tha t is currently happening) that addressed
your specific issue is:
https://bugs.launchpad.net/horizon/+bug/1331406


I have proposed a fix for Keystone that would revert the PKIZ default:
https://review.openstack.org/#/c/101714/
<https://review.openstack.org/#/c/101714/>


Depending on the fixes upcoming for the django_openstack_auth module, it
may make sense to temporarily revert the PKIZ provider default until we
can solve the issues with the django auth module and horizon when PKIZ is
enabled. If this review is not needed
 based on how the horizon issues are corrected, it will be abandoned.


I think this is also showing some gaps in our testing, notably that the
django_openstack_auth module isn't being exercised on the integration
tests. I'll aim to hit up Horizon team and work with them and the QA folks
to make sure we cover this gap in the
 future.


--Morgan


On Saturday, June 21, 2014, Mike Spreitzer <mspreitz at us.ibm.com> wrote:

Since Friday I have been getting this misbehavior: enter username and
password, hit login, and it shows you the login page again.


Sean Dague --- [openstack-dev] horizon failing on icehouse 100%, currently
blocking all patches ---




From:"Sean Dague" <sean at dague.net>To"openstack-dev"
<openstack-dev at lists.openstack.org>Date:Sat, Jun 21, 2014
12:54Subject[openstack-dev] horizon failing on icehouse 100%, currently
blocking all patches________________________________________

Horizon in icehouse is now 100% failing

 [Sat Jun 21 16:17:35 2014] [error] Internal Server Error: /
[Sat Jun 21 16:17:35 2014] [error] Traceback (most recent call last):
[Sat Jun 21 16:17:35 2014] [error]   File
"/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py",
line 112, in get_response
[Sat Jun 21 16:17:35 2014] [error]     response =
wrapped_callback(request, *callback_args, **callback_kwargs)
[Sat Jun 21 16:17:35 2014] [error]   File
"/usr/local/lib/python2.7/dist-packages/django/views/decorators/vary.py",
line
36, in inner_func
[Sat Jun 21 16:17:35 2014] [error]     response = func(*args, **kwargs)
[Sat Jun 21 16:17:35 2014] [error]   File
"/opt/stack/old/horizon/openstack_dashboard/wsgi/../../openstack_dashboard/
views.py",
line 35, in splash
[Sat Jun 21 16:17:35 2014] [error]     form = views.Login(request)
[Sat Jun 21 16:17:35 2014] [error] AttributeError: 'module' object has
no attribute 'Login'

This suspiciously times with django_openstack_auth 1.1.6 being released.
http://logstash.openstack.org/#eyJzZWFyY2giOiJcIkF0dHJpYnV0ZUVycm9yOiAnbW9k
dWxlJyBvYmplY3QgaGFzIG5vIGF0dHJpYnV0ZSAnTG9naW4nXCIiLCJmaWVsZHMiOltdLCJvZmZ
zZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6ey
J1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0MDMzNjk0MjQ4NjR9

Because this breaks smoke tests on icehouse, it means that any project
with upgrade testing fails.

Would be great if horizon folks code make this a top priority. Also, in
future, releasing new library versions on a saturday maybe best avoided. :)

-Sean

-- 
Sean Dague
http://dague.net

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev