Open Stack

On Tue, Jun 17, 2014 at 01:12:45PM +0100, Matthew Booth wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 17/06/14 12:36, Sean Dague wrote:
> > On 06/17/2014 07:23 AM, Daniel P. Berrange wrote:
> >> If would be nice if gerrit had simple keyword tagging so any
> >> reviewer can tag an existing commit as "trivial", but that
> >> doesn't seem to exist as a concept yet.
> >> 
> >> So an alternative perhaps submit trivial stuff using a well
> >> known topic eg
> >> 
> >> # git review --topic trivial
> >> 
> >> Then you can just query all changes in that topic to find easy
> >> stuff to approve.
> > 
> > It could go in the commit message:
> > 
> > TrivialFix
> > 
> > Then could be queried with - 
> > https://review.openstack.org/#/q/message:TrivialFix,n,z
> > 
> > If a reviewer felt it wasn't a trivial fix, they could just edit
> > the commit message inline to drop it out.

Yes, that would be a workable idea.

> +1. If possible I'd update the query to filter out anything with a -1.
> 
> Where do we document these things? I'd be happy to propose a docs update.

Lets see if any other nova cores dissent, but then can add it to these 2
wiki pages

  https://wiki.openstack.org/wiki/ReviewChecklist
  https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|