[openstack-dev] [nova][ironic] what to do with unit test failures from ironic api contract

Day, Phil philip.day at hp.com
Fri Jun 13 13:30:34 UTC 2014

Hi Folks,

A recent change introduced a unit test to "warn/notify developers" when they make a change which will break the out of tree Ironic virt driver:   https://review.openstack.org/#/c/98201

Ok - so my change (https://review.openstack.org/#/c/68942) broke it as it adds some extra parameters to the virt drive power_off() method - and so I now feel suitable warned and notified - but am not really clear what I'm meant to do next.

So far I've:

-          Modified the unit test in my Nova patch so it now works

-          Submitted an Ironic patch to add the extra parameters (https://review.openstack.org/#/c/99932/)

As far as I can see there's no way to create a direct dependency from the Ironic change to my patch - so I guess its down to the Ironic folks to wait and accept it in the correct sequence ?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140613/ece37e2d/attachment.html>

More information about the OpenStack-dev mailing list