Open Stack

I've submitted a patch that copies the compute http response validation 
structure for the 'cinder list' request.

https://review.openstack.org/96440

I'm having trouble getting it through the gate, but input from the 
cinder group about whether this is useful work that I should persist 
with would be appreciated.

Thanks,
Ollie


On 01/05/14 05:02, Ken'ichi Ohmichi wrote:
> Hi David,
>
> 2014-05-01 5:44 GMT+09:00 David Kranz <dkranz at redhat.com>:
>> There have been a lot of patches that add the validation of response dicts.
>> We need a policy on whether this is required or not. For example, this patch
>>
>> https://review.openstack.org/#/c/87438/5
>>
>> is for the equivalent of 'cinder service-list' and is a basically a copy of
>> the nova test which now does the validation. So two questions:
>>
>> Is cinder going to do this kind of checking?
>> If so, should new tests be required to do it on submission?
> I'm not sure someone will add the similar validation, which we are adding to
> Nova API tests, to Cinder API tests also. but it would be nice for Cinder and
> Tempest. The validation can be applied to the other projects(Cinder, etc)
> easily because the base framework is implemented in common rest client
> of Tempest.
>
> When adding new tests like https://review.openstack.org/#/c/87438 , I don't
> have strong opinion for including the validation also. These schemas will be
> large sometimes and the combination in the same patch would make reviews
> difficult. In current Nova API test implementations, we are separating them
> into different patches.
>
>
> Thanks
> Ken'ichi Ohmichi
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev