[openstack-dev] [qa] shared review dashboard proposal

Sean Dague sean at dague.net
Mon Jun 2 20:31:42 UTC 2014

On 06/02/2014 01:05 PM, Sean Dague wrote:
> On 06/02/2014 09:21 AM, Matthew Treinish wrote:
> <snip>
>>> The url for this is -  http://goo.gl/g4aMjM
>>> (the long url is very long:
>>> https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade+OR+project%3Aopenstack%2Fqa-specs%29+status%3Aopen+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%2Cjenkins+NOT+label%3ACode-Review%3C%3D-1%2Cself+NOT+label%3ACode-Review%3E%3D1%2Cself&title=QA+Review+Inbox&QA+Specs=project%3Aopenstack%2Fqa-specs&Needs+Feedback+%28Changes+older+than+5+days+that+have+not+been+reviewed+by+anyone%29=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Needs+final+%2B2=%28project%3Aopenstack%2Ftempest+OR+project%3Aopenstack-dev%2Fgrenade%29+label%3ACode-Review%3E%3D2+limit%3A50&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+2days%29=NOT+label%3ACode-Review%3C%3D2+age%3A2d
>>> The url can be regenerated easily using the gerrit-dash-creator.
>> These generated URLs don't quite work as expected for me, I see a bunch of -1s
>> from jenkins in all the sections. Other things like reviews with -2s showing up
>> "in need final +2", or reviews with -2s and +2s from me being listed in the "but
>> haven't voted in the current revision". Also the top section just seems to list
>> every open QA program review regardless of it's current review state.
>> I'll take a look at the code and see if I can help figure out what's going on.
> It appears that there is some issue in Firefox vs. Gerrit here where
> Firefox is incorrectly over unescaping the URL, thus it doesn't work.
> Chrome works fine. As I'm on Linux that's the extent of what I can
> natively test.
> I filed a Firefox bug here -
> https://bugzilla.mozilla.org/show_bug.cgi?id=1019073

The following updated url seems to work for firefox: https://goo.gl/oGYH4s

Thanks to dtantsur for figuring out the extra escaping on commas you
needed to work with firefox.


Sean Dague

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140602/f95044bb/attachment.pgp>

More information about the OpenStack-dev mailing list