Open Stack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 30/07/14 19:22, Kevin L. Mitchell wrote:
> On Wed, 2014-07-30 at 09:01 +0200, Flavio Percoco wrote:
>> As a stable-maint, I'm always hesitant to review patches I've no 
>> understanding on, hence I end up just checking how big is the
>> patch, whether it adds/removes new configuration options etc but,
>> the real review has to be done by someone with good understanding
>> of the change.
>> 
>> Something I've done in the past is adding the folks that had
>> approved the patch on master to the stable/maint review. They
>> should know that code already, which means it shouldn't take them
>> long to review it. All the sanity checks should've been done
>> already.
>> 
>> With all that said, I'd be happy to give *-core approval
>> permissions on stable branches, but I still think we need a
>> dedicated team that has a final (or at least relevant) word on
>> the patches.
> 
> Maybe what we need to do is give *-core permission to +2 the
> patches, but only stable/maint team has *approval* permission.
> Then, the cores can review the code, and stable/maint only has to
> verify applicability to the stable branch…
> 

+2 for the idea. :)

Cheers,
/Ihar
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJT2hg4AAoJEC5aWaUY1u57xJUH+waJ3GKorN/8gxr6XjY330+L
60UmdVZ/WHZcj3GPm7ZjNqMQCdoXRWnmZLBUry+GzpuHcMXSHRW/H/bMiAVhufP4
+VWXu6SlIfzlSRWZNkI4k2uoyfYIJKcpPZJTpU51fjC0JWKmdwHUBB/YBa41oC9f
BV3xVih389sbfLPUO8nvbjHk6Vo+5eCbzqXhefVxOnuP+mbaIJTek6G5lmxU/Vem
LdUdVwN2pCC4nt6JF+WDme6DZ6CV8lwbu1cgqNJojZFp+F1vFYIU0oyQrBY11/96
7NHrsVecI2MvGtPsl3S+T9INV4Z35BAsfJ5Qac/KzGmLCL/aapkQgv8KxPPqI4w=
=+oPU
-----END PGP SIGNATURE-----