[openstack-dev] [ALL] Removing the tox==1.6.1 pin

Daniel P. Berrange berrange at redhat.com
Wed Jul 30 11:13:22 UTC 2014


On Fri, Jul 25, 2014 at 02:38:49PM -0700, Clark Boylan wrote:
> New tox sets a random PYTHONHASHSEED value by default. Arguably this is
> a good thing as it forces you to write code that handles unknown hash
> seeds, but unfortunately many projects' unittests don't currently deal
> with this very well. A work around is to hard set a PYTHONHASHSEED of 0
> in tox.ini files. I have begun to propose these changes to the projects
> that I have tested and found to not handle random seeds. It would be
> great if we could get these reviewed and merged so that infra can update
> the version of tox used on our side.

NB, the problem is not merely restricted to unit tests. The first test
failure I looked at turned out to be a problem in a database migration
script, so if anyone sets a non-zero PYTHONHASHSEED in production for
security reasons, they'd be exposed to non-deterministic behaviour too

  https://review.openstack.org/#/c/110605/

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



More information about the OpenStack-dev mailing list