[openstack-dev] [nova] Configuring libivrt VIF driver

Russell Bryant rbryant at redhat.com
Wed Jul 23 20:19:25 UTC 2014


On 07/23/2014 03:04 PM, Dan Smith wrote:
>> FWIW, I do actually agree with not exposing plugin points to
>> things that are not stable APIs and if they didn't already exist,
>> I'd not approve adding them. I'd actually go further and say not
>> even the virt driver API should be a plugin point, since we
>> arbitrarily change it during development any time we need to. The
>> latter is not a serious or practical view right now though given
>> our out of tree Docker/Ironic drivers. I'm just concerned that
>> we've had these various extension points exposed for a long time
>> and we've not clearly articulated that they are liable to be
>> killed off (besides marking vif_driver as deprecated)
> 
> Yep, I think we agree. I think that as a project we've identified 
> exposing plug points that aren't stable (or intended to be
> replaceable) as a bad thing, and thus we should be iterating on
> removing them. Especially if we're generous with our
> deprecate-before-remove rules, then I think that we're not likely
> to bite anyone suddenly with something they're shipping while
> working it upstream in parallel. I *really* thought we had called
> this one out on the ReleaseNotes, but apparently that didn't happen
> (probably because we decide to throw in those helper classes to
> avoid breaking configs). Going forward, marking it deprecated in
> the code for a cycle, noting it on the release notes, and then
> removing it the next cycle seems like plenty of warning.

+1 on this stance.  I'd like to remove all plug points that we don't
intend to be considered stable APIs with a reasonable deprecation cycle.

I personally don't consider any API in Nova except the v2 REST API to
be a stable API.

-- 
Russell Bryant



More information about the OpenStack-dev mailing list