Open Stack

The good news is that the head of the queue was merged last night, so
it's now only 15 deep :) Even better, the next 3 patches all have +2s
already, so fingers cross they'll go in some time soon.

The rest mostly have +1s, but a couple are currently sitting naked.
Having +1s bumps them up the review queue and I don't want to lose
momentum on this series, so if people could please look at the following
I'd be very grateful:

* VMware: Create VMwareImage object for image metadata
https://review.openstack.org/#/c/104145/

Merge conflict due to IMAGE_API, but only in code which was being
removed anyway. IMAGE_API isn't relevant to the added code afaict, as
we're no longer calling glance to get image metadata.

* VMware: Remove references to ebs_root from spawn()
https://review.openstack.org/#/c/104147/

I touched this in response to review comments in patch 6, and it hasn't
been re-reviewed since. Changes:
  _resize_if_required() -> _extend_if_required()
  Clearer comment about broken block_device_mapping behaviour
  Ignore irrelevant details of exception checking in
test_spawn_mask_block_device_info_password()

* VMware: Add _create_array_of_type utility function to fake
https://review.openstack.org/#/c/105737/

Not yet reviewed! However, it's the addition of a 19 line testing
utility function. Seconds to review...

* VMware: Fix type of VM's config.hardware.device in fake
https://review.openstack.org/#/c/105738/

Not yet reviewed! The code change is simple enough, but you might want
to assure yourself that the change to fake reflects the actual behaviour
of vSphere.

These are in series order, so if you can only review n, please review
the first n :) The first 2 are the meat of the series so somewhat more
involved. However, they've all been well-reviewed already, so should
hopefully be just a quick re-review.

Note to self: When rebasing, make a note of merge conflicts and add a
summary of required changes to a comment in gerrit.

Matt
-- 
Matthew Booth
Red Hat Engineering, Virtualisation Team

Phone: +442070094448 (UK)
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490