Open Stack

Okay, sounds good!  I just figured a smaller patch might move through faster
:).
On 07/03/14 07:55:14 PM, Fuente, Pablo A wrote:
> Yes I know that, but we need the big patch in order to get our V2 REST
> API working, so I asked to review this patch instead of submitting a new
> one.
> 
> On Wed, 2014-07-02 at 17:24 -0400, Ryan Petrello wrote:
> > That's a pretty notable review to accommodate the pecan change.  In the
> > meantime, wouldn't something like this would get the py26 and py27 tests
> > passing?
> > 
> > index 9aced3f..4051fad 100644
> > --- a/climate/tests/api/test_root.py
> > +++ b/climate/tests/api/test_root.py
> > @@ -22,8 +22,7 @@ class TestRoot(api.APITest):
> >          response = self.get_json('/',
> >                                   expect_errors=True,
> >                                   path_prefix='')
> > -        self.assertEqual(response.status_int, 200)
> > -        self.assertEqual(response.content_type, "text/html")
> > +        self.assertEqual(response.status_int, 204)
> >          self.assertEqual(response.body, '')
> > 
> > On 07/02/14 09:08:35 PM, Fuente, Pablo A wrote:
> > > Blazar cores,
> > > 	Please review https://review.openstack.org/99389. We need this merged
> > > ASAP in order to get a +1 from Jenkins in our py26 and py27 jobs. Pecan
> > > new version returns a 204 instead 200 in one case (when the API returns
> > > and empty dictionary) and one test case is failing for this reason. This
> > > patch solve the bug as a side effect, because it returns the versions
> > > instead of an empty dictionary.
> > > 
> > > Pablo.
> > > _______________________________________________
> > > OpenStack-dev mailing list
> > > OpenStack-dev at lists.openstack.org
> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-- 
Ryan Petrello
Senior Developer, DreamHost
ryan.petrello at dreamhost.com