Open Stack

On 01/27/2014 11:03 AM, Macdonald-Wallace, Matthew wrote:
>>> I've also noticed just now that we appear to be "re-inventing" some parts of
>> the logging framework (openstack.common.log.WriteableLogger for example
>> appears to be a "catchall" when we should just be handing off to the default
>> logger and letting the python logging framework decide what to do IMHO).
>>
>> WriteableLogger exists for a very specific reason: eventlet. Eventlet assumes a
>> file object for logging, not a python logger.
>>
>> I've proposed a change for that -
>> https://github.com/eventlet/eventlet/pull/75 - but it's not yet upstream.
> 
> Thanks for clearing that up, makes a lot more sense now!
> 
> So when the change is merged upstream we can get rid of that in our code as well?

I'm pretty sure that's the only place it's used, so my hope is yes.

	-Sean

-- 
Sean Dague
Samsung Research America
sean at dague.net / sean.dague at samsung.com
http://dague.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 547 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140130/77cd5f42/attachment.pgp>