[openstack-dev] [Hacking] unit test code is too less

Dirk Müller dirk at dmllr.de
Thu Jan 23 11:06:37 UTC 2014


Hi Zhi Qiang,

> for i.e. the hacking rule h233 in hacking looks not so robust,
> https://github.com/openstack-dev/hacking/blob/master/hacking/core.py#L345
> it cannot detect
>
> \bprint$
> \bprint >>>xxx, (\s+

It currently detects both as a violation of the rule, which is IMHO
correct. Please note that the behavior of

  print

depends on if its an operator (then it prints a newline) and a
function (then it does nothing)


Greetings,
Dirk



More information about the OpenStack-dev mailing list