Open Stack

On Wed, Jan 15, 2014 at 01:42:34PM -0500, Sean Dague wrote:
> On 01/15/2014 01:00 PM, Steven Dake wrote:
> > On 01/15/2014 10:28 AM, Daniel P. Berrange wrote:
> >> On Wed, Jan 15, 2014 at 09:56:58AM -0700, Steven Dake wrote:
> >>> Hi,
> >>>
> >>> Ken'ichi Omichi submitted a change [1] in devstack to change the
> >>> default log level to 1 for libvirt.  This results in continual spam
> >>> to /var/log/messages in my development system, even after exiting
> >>> devstack.  The spam looks like:
> >>> "
> >>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
> >>> 1480: debug : virFileClose:90 : Closed fd 8
> >>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
> >>> 1480: debug : virFileClose:90 : Closed fd 9
> >>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
> >>> 1480: debug : virFileClose:90 : Closed fd 10
> >>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
> >>> 1480: debug : virFileClose:90 : Closed fd 11
> >>> "
> >>> in a continual loop
> >>>
> >>> I submitted a change [2] that sets the default to level 2 (info +
> >>> warnings + errors) which was -1'ed by Sean Dague.  His suggestion
> >>> was to take the discussion upstream so consensus around what the
> >>> default should be can be made so this doesn't end up getting changed
> >>> every week.
> >>>
> >>> The core mission of devstack is to provide a development environment
> >>> for developers.  The fact that it is being used in the gate seems
> >>> somewhat ancillary to it's mission, and forcing a default of "spam
> >>> the system logs with tons of libvirt messages" seems counter to the
> >>> core mission of devstack.  As is, without modification devstack
> >>> makes looking at anything useful in my system logs impossible
> >>> without grep -v libvirt and is intrusive to developer's
> >>> workstations.
> >> Agreed, it is complete insanity to set 'log_level=1' on *any* hosts.
> >> The level of debug info that generates is so enourmous that you'd
> >> never wanted to look at it. Debugging from that would be like trying
> >> to find a specific piece of hay in a haystack. That original devstack
> >> change should just be completely reverted.
> >>
> >> It would be useful if Jenkins machines had an elevated log level,
> >> but even there you definitely don't want to set log_level=1. I
> >> would suggest that for Jenkin's machines *only* we want to try
> >>
> >>    log_filters="1:libvirt 1:qemu 1:conf 1:security 3:event 3:json 3:file 1:util"
> >>    log_outputs="1:file:/var/log/libvirt/libvirtd.log"
> >>
> >> Don't touch log settings at all on general developers' machines.
> >> If & when developers want to toubleshoot something they are
> >> perfectly able to do so without us making unhelpful decisions
> >> for them.
> > 
> > Daniel,
> > 
> > Makes sense to me.
> > 
> > https://review.openstack.org/#/c/66900/
> 
> We already do all sorts of changing of things on developer machines for
> devstack, so changing libvirt config does not seem out of scope. I agree
> that current level of debug is probably not right, which is why I wanted
> this on the list, so let's figure out what the right level is and set it.

A more suitable debugging level for troubleshooting is already
set by this change

  https://review.openstack.org/#/c/65834/2/lib/nova

based on a previous recommendation of mine in the referenced bug, which
is close to what I suggested above

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|