Open Stack

On 01/15/2014 10:28 AM, Daniel P. Berrange wrote:
> On Wed, Jan 15, 2014 at 09:56:58AM -0700, Steven Dake wrote:
>> Hi,
>>
>> Ken'ichi Omichi submitted a change [1] in devstack to change the
>> default log level to 1 for libvirt.  This results in continual spam
>> to /var/log/messages in my development system, even after exiting
>> devstack.  The spam looks like:
>> "
>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
>> 1480: debug : virFileClose:90 : Closed fd 8
>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
>> 1480: debug : virFileClose:90 : Closed fd 9
>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
>> 1480: debug : virFileClose:90 : Closed fd 10
>> Jan 14 08:13:49 bigiron libvirtd: 2014-01-14 15:13:49.334+0000:
>> 1480: debug : virFileClose:90 : Closed fd 11
>> "
>> in a continual loop
>>
>> I submitted a change [2] that sets the default to level 2 (info +
>> warnings + errors) which was -1'ed by Sean Dague.  His suggestion
>> was to take the discussion upstream so consensus around what the
>> default should be can be made so this doesn't end up getting changed
>> every week.
>>
>> The core mission of devstack is to provide a development environment
>> for developers.  The fact that it is being used in the gate seems
>> somewhat ancillary to it's mission, and forcing a default of "spam
>> the system logs with tons of libvirt messages" seems counter to the
>> core mission of devstack.  As is, without modification devstack
>> makes looking at anything useful in my system logs impossible
>> without grep -v libvirt and is intrusive to developer's
>> workstations.
> Agreed, it is complete insanity to set 'log_level=1' on *any* hosts.
> The level of debug info that generates is so enourmous that you'd
> never wanted to look at it. Debugging from that would be like trying
> to find a specific piece of hay in a haystack. That original devstack
> change should just be completely reverted.
>
> It would be useful if Jenkins machines had an elevated log level,
> but even there you definitely don't want to set log_level=1. I
> would suggest that for Jenkin's machines *only* we want to try
>
>     log_filters="1:libvirt 1:qemu 1:conf 1:security 3:event 3:json 3:file 1:util"
>     log_outputs="1:file:/var/log/libvirt/libvirtd.log"
>
> Don't touch log settings at all on general developers' machines.
> If & when developers want to toubleshoot something they are
> perfectly able to do so without us making unhelpful decisions
> for them.

Daniel,

Makes sense to me.

https://review.openstack.org/#/c/66900/

> Regards,
> Daniel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140115/937d9cba/attachment.html>