Open Stack

On Wed, Jan 15, 2014 at 11:09 AM, Vishvananda Ishaya
<vishvananda at gmail.com>wrote:

>
> On Jan 15, 2014, at 6:40 AM, Doug Hellmann <doug.hellmann at dreamhost.com>
> wrote:
>
>
>
>
> On Wed, Jan 15, 2014 at 6:51 AM, Victor Sergeyev <vsergeyev at mirantis.com>wrote:
>
>> Hello All.
>>
>> As for lockutils - a few days ago I wondered why we used custom oslo
>> module instead of lockfile library [1]. AFAIK, it must be due to this bug
>> [2] (please fix me, if I wrong).
>>
>> This library is available on github [3] and there is a pull-request
>> fixing the bug [4], but unfortunately it hasn’t been merged yet. And seems
>> that this project is not maintained anymore - author told, that he “haven't
>> done anything with it in a few years” [5].
>>
>> So my question is - can we start maintaining this library (put it on
>> stackforge) and use it instead of oslo.lockutils? Or maybe we could include
>> parts of oslo.lockutils into lockfile? Or vice versa, incorporate lockfile
>> into oslo.lockutils?
>>
>
> That might make sense.
>
> It looks like the lockfile package on PyPI is meant to be portable to
> Windows, and I'm not sure if we care about that. Does it provide any other
> useful features or API improvements over the lockfiles module we have?
> We'll still need a wrapper, since we have configuration options in our
> module now.
>
> How much work would it be to transition to the other library?
>
> Doug
>
>
> We used lockfile in the early days of openstack:
>
> https://github.com/openstack/nova/blob/essex-rc2/nova/utils.py#L957
>
> and it was plagued with many problems. Switching to fsync based locks
> solved a lot of these
> issues.
>

Hurray for institutional memory! :-)

Thanks, Vish, we'll stick with the version in oslo and work on fixing any
issues it has.

Doug



>
> Vish
>
>
>
>>
>> [1] https://pypi.python.org/pypi/lockfile
>> [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632857
>> [3] https://github.com/smontanaro/pylockfile
>> [4] https://github.com/smontanaro/pylockfile/pull/3
>> [5] https://github.com/smontanaro/pylockfile/pull/3#issuecomment-32085554
>>
>>
>> On Wed, Jan 15, 2014 at 1:00 AM, Michael Still <mikal at stillhq.com> wrote:
>>
>>> On Wed, Jan 15, 2014 at 9:27 AM, Ben Nemec <openstack at nemebean.com>
>>> wrote:
>>>
>>> > It would be nice to get lockutils graduated to solve some of the issues
>>> > mentioned in the oslo.db section, but I believe we do have an
>>> outstanding
>>> > question regarding its behavior without lock_path being set.  I think
>>> Clint
>>> > was on board with Sean's proposed solution after quite a bit of
>>> discussion
>>> > (
>>> http://lists.openstack.org/pipermail/openstack-dev/2013-December/021620.html
>>> ),
>>> > so it's possible we could just restore that patch and call it done,
>>> but it
>>> > should probably be addressed somehow before graduation.
>>>
>>> I committed a while ago (at the last summit IIRC) to working on
>>> getting lockutils released as a library, but I haven't managed to get
>>> that done yet. If it is blocking other people I can prioritise that
>>> work to being higher on my todo list.
>>>
>>> Part of the problem here is that its my first oslo graduation, so I
>>> need to figure out what to do...
>>>
>>> Michael
>>>
>>> --
>>> Rackspace Australia
>>>
>>> _______________________________________________
>>> OpenStack-dev mailing list
>>> OpenStack-dev at lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140115/b18c1181/attachment.html>