[openstack-dev] [horizon] Javascript checkstyle improvement

Maxime Vidori maxime.vidori at enovance.com
Fri Jan 3 09:10:35 UTC 2014


Someone said Grunt?

----- Original Message -----
From: "Matthias Runge" <mrunge at redhat.com>
To: openstack-dev at lists.openstack.org
Sent: Friday, January 3, 2014 9:52:48 AM
Subject: Re: [openstack-dev] [horizon] Javascript checkstyle improvement

On 01/03/2014 09:37 AM, Radomir Dopieralski wrote:

> [snip]
> 
> This is actually not a problem at all, because the way jshint works now,
> we have to explicitly list the files to be checked against those
> rules. That means, that we can only check our own code, and not the
> included libraries. Of course, the reviewers have to pay attention to
> make sure that all the non-library code is added to the list, but we
> don't really get new files that often.
> 
Yeah, jshint needs to be switched on explicitly for each file. That
tends to be forgotten on new files, which is not ideal either.

Matthias

_______________________________________________
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list