Open Stack

works for me, less complexity +1

On Fri, Dec 12, 2014 at 11:09 AM, Timur Sufiev <tsufiev at mirantis.com> wrote:

> It seems to me that the consensus on keeping the simpler approach -- to
> make Bootstrap data-backdrop="static" as the default behavior -- has been
> reached. Am I right?
>
> On Thu, Dec 4, 2014 at 10:59 PM, Kruithof, Piet <
> pieter.c.kruithof-jr at hp.com> wrote:
>>
>> My preference would be “change the default behavior to 'static’” for the
>> following reasons:
>>
>> - There are plenty of ways to close the modal, so there’s not really a
>> need for this feature.
>> - There are no visual cues, such as an “X” or a Cancel button, that
>> selecting outside of the modal closes it.
>> - Downside is losing all of your data.
>>
>> My two cents…
>>
>> Begin forwarded message:
>>
>> From: "Rob Cresswell (rcresswe)" <rcresswe at cisco.com<mailto:
>> rcresswe at cisco.com>>
>> To: "OpenStack Development Mailing List (not for usage questions)" <
>> openstack-dev at lists.openstack.org<mailto:
>> openstack-dev at lists.openstack.org>>
>> Date: December 3, 2014 at 5:21:51 AM PST
>> Subject: Re: [openstack-dev] [horizon] [ux] Changing how the modals are
>> closed in Horizon
>> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <
>> openstack-dev at lists.openstack.org<mailto:
>> openstack-dev at lists.openstack.org>>
>>
>> +1 to changing the behaviour to ‘static'. Modal inside a modal is
>> potentially slightly more useful, but looks messy and inconsistent, which I
>> think outweighs the functionality.
>>
>> Rob
>>
>>
>> On 2 Dec 2014, at 12:21, Timur Sufiev <tsufiev at mirantis.com<mailto:
>> tsufiev at mirantis.com>> wrote:
>>
>> Hello, Horizoneers and UX-ers!
>>
>> The default behavior of modals in Horizon (defined in turn by Bootstrap
>> defaults) regarding their closing is to simply close the modal once user
>> clicks somewhere outside of it (on the backdrop element below and around
>> the modal). This is not very convenient for the modal forms containing a
>> lot of input - when it is closed without a warning all the data the user
>> has already provided is lost. Keeping this in mind, I've made a patch [1]
>> changing default Bootstrap 'modal_backdrop' parameter to 'static', which
>> means that forms are not closed once the user clicks on a backdrop, while
>> it's still possible to close them by pressing 'Esc' or clicking on the 'X'
>> link at the top right border of the form. Also the patch [1] allows to
>> customize this behavior (between 'true'-current one/'false' - no backdrop
>> element/'static') on a per-form basis.
>>
>> What I didn't know at the moment I was uploading my patch is that David
>> Lyle had been working on a similar solution [2] some time ago. It's a bit
>> more elaborate than mine: if the user has already filled some some inputs
>> in the form, then a confirmation dialog is shown, otherwise the form is
>> silently dismissed as it happens now.
>>
>> The whole point of writing about this in the ML is to gather opinions
>> which approach is better:
>> * stick to the current behavior;
>> * change the default behavior to 'static';
>> * use the David's solution with confirmation dialog (once it'll be
>> rebased to the current codebase).
>>
>> What do you think?
>>
>> [1] https://review.openstack.org/#/c/113206/
>> [2] https://review.openstack.org/#/c/23037/
>>
>> P.S. I remember that I promised to write this email a week ago, but
>> better late than never :).
>>
>> --
>> Timur Sufiev
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org<mailto:
>> OpenStack-dev at lists.openstack.org>
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org<mailto:
>> OpenStack-dev at lists.openstack.org>
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
> --
> Timur Sufiev
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20141212/2ecdd28e/attachment.html>