[openstack-dev] [hacking] proposed rules drop for 1.0
Sahid Orentino Ferdjaoui
sahid.ferdjaoui at redhat.com
Tue Dec 9 14:56:55 UTC 2014
On Tue, Dec 09, 2014 at 08:16:34AM -0500, Sean Dague wrote:
> On 12/09/2014 07:32 AM, Sahid Orentino Ferdjaoui wrote:
> > On Tue, Dec 09, 2014 at 06:39:43AM -0500, Sean Dague wrote:
> >> I'd like to propose that for hacking 1.0 we drop 2 groups of rules entirely.
> >> 1 - the entire H8* group. This doesn't function on python code, it
> >> functions on git commit message, which makes it tough to run locally. It
> >> also would be a reason to prevent us from not rerunning tests on commit
> >> message changes (something we could do after the next gerrit update).
> > -1, We probably want to recommend a git commit message more stronger
> > formatted mainly about the first line which is the most important. It
> > should reflect which part of the code the commit is attended to update
> > that gives the ability for contributors to quickly see on what the
> > submission is related;
> > An example with Nova which is quite big: api, compute,
> > doc, scheduler, virt, vmware, libvirt, objects...
> > We should to use a prefix in the first line of commit message. There
> > is a large number of commits waiting for reviews, that can help
> > contributors with a knowledge in a particular domain to identify
> > quickly which one to pick.
> And how exactly do you expect a machine to decide if that's done correctly?
Keep what we already have then let community move forward about how to
make those rules better.
Does it is something we want to remove machine validations to make
them human validations ? Contributors already have a ton of work and I
guess we are agree the aim is not to remove validations to have all in
green in the dashboard.
> >> 2 - the entire H3* group - because of this -
> >> https://review.openstack.org/#/c/140168/2/nova/tests/fixtures.py,cm
> >> A look at the H3* code shows that it's terribly complicated, and is
> >> often full of bugs (a few bit us last week). I'd rather just delete it
> >> and move on.
> >> -Sean
> >> --
> >> Sean Dague
> >> http://dague.net
> >> _______________________________________________
> >> OpenStack-dev mailing list
> >> OpenStack-dev at lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> Sean Dague
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
More information about the OpenStack-dev