Open Stack

On Fri, Dec 05, 2014 at 01:41:59PM +0000, Daniel P. Berrange wrote:
> On Fri, Dec 05, 2014 at 11:05:28AM +1100, Michael Still wrote:
> > One of the things that happens over time is that some of our core
> > reviewers move on to other projects. This is a normal and healthy
> > thing, especially as nova continues to spin out projects into other
> > parts of OpenStack.
> > 
> > However, it is important that our core reviewers be active, as it
> > keeps them up to date with the current ways we approach development in
> > Nova. I am therefore removing some no longer sufficiently active cores
> > from the nova-core group.
> > 
> > I’d like to thank the following people for their contributions over the years:
> > 
> > * cbehrens: Chris Behrens
> > * vishvananda: Vishvananda Ishaya
> > * dan-prince: Dan Prince
> > * belliott: Brian Elliott
> > * p-draigbrady: Padraig Brady
> > 
> > I’d love to see any of these cores return if they find their available
> > time for code reviews increases.
> 
> What stats did you use to decide whether to cull these reviewers ? Looking
> at the stats over a 6 month period, I think Padraig Brady is still having
> a significant positive impact on Nova - on a par with both cerberus and
> alaski who you've not proposing for cut. I think we should keep Padraig
> on the team, but probably suggest cutting Markmc instead
> 
>   http://russellbryant.net/openstack-stats/nova-reviewers-180.txt
> 
> +-----------------------------+----------------------------------------+----------------+
> |           Reviewer          | Reviews   -2  -1  +1  +2  +A    +/- %  | Disagreements* |
> +-----------------------------+----------------------------------------+----------------+
> |         berrange **         |    1766   26 435  12 1293 357    73.9% |  157 (  8.9%)  |
> |         jaypipes **         |    1359   11 378 436 534 133    71.4%  |  109 (  8.0%)  |
> |           jogo **           |    1053  131 326   7 589 353    56.6%  |   47 (  4.5%)  |
> |           danms **          |     921   67 381  23 450 167    51.4%  |   32 (  3.5%)  |
> |          oomichi **         |     889    4 306  55 524 182    65.1%  |   40 (  4.5%)  |
> |        johngarbutt **       |     808  319 227  10 252 145    32.4%  |   37 (  4.6%)  |
> |          mriedem **         |     642   27 279  25 311 136    52.3%  |   17 (  2.6%)  |
> |          klmitch **         |     606    1  90   2 513  70    85.0%  |   67 ( 11.1%)  |
> |         ndipanov **         |     588   19 179  10 380 113    66.3%  |   62 ( 10.5%)  |
> |        mikalstill **        |     564   31  34   3 496 207    88.5%  |   20 (  3.5%)  |
> |          cyeoh-0 **         |     546   12 207  30 297 103    59.9%  |   35 (  6.4%)  |
> |          sdague **          |     511   23  89   6 393 229    78.1%  |   25 (  4.9%)  |
> |         russellb **         |     465    6  83   0 376 158    80.9%  |   23 (  4.9%)  |
> |          alaski **          |     415    1  65  21 328 149    84.1%  |   24 (  5.8%)  |
> |         cerberus **         |     405    6  25  48 326 102    92.3%  |   33 (  8.1%)  |
> |       p-draigbrady **       |     376    2  40   9 325  64    88.8%  |   49 ( 13.0%)  |
> |          markmc **          |     243    2  54   3 184  69    77.0%  |   14 (  5.8%)  |
> |         belliott **         |     231    1  68   5 157  35    70.1%  |   19 (  8.2%)  |
> |        dan-prince **        |     178    2  48   9 119  29    71.9%  |   11 (  6.2%)  |
> |         cbehrens **         |     132    2  49   2  79  19    61.4%  |    6 (  4.5%)  |
> |        vishvananda **       |      54    0   5   3  46  15    90.7%  |    5 (  9.3%)  |
> 

+1

Padraig gave to us several robust reviews on important topics. Lose him
will make more difficult the work on nova.

s.