Open Stack

On 23/08/14 00:09, Sean Dague wrote:
> Earlier this week the freshness checks (the ones that required passing
> results within 24 hrs for a change to go into the gate) were removed to
> try to conserve nodes as we get to crunch time. The hopes were that
> review teams had enough handle on what when code in their program got
> into a state that it *could not* pass it's own unit tests to not approve
> that code.
>
> The attached screen shot shows that this is not currently true with
> Glance. All glance changes will 100% fail their unit tests now. The root
> fix might be here - https://review.openstack.org/#/c/115342/ which has 2
> -1s and has been out for review for 3 days.
The unit test failure is about the order of some collections, such as 
dict, list, etc, which introduced by bug 
https://bugs.launchpad.net/nova/+bug/1348818. So that means some 
failures arise randomly. As a result, the patch owner may just 
re-trigger Jenkins and the failure may be gone. Therefore, it is not 
discovered by the reviewers. For example, the patch 115342 failed again 
since there are some other order issue. BTW, I'm working on that patch 
right now.
> Realistically Glance was the biggest offender of this in the past, and
> honestly the top reason for putting freshness checks in the gate in the
> first place.
>
> Does anyone from the Glance team have some ideas on better ways to keep
> the team up on the fact that Glance is in a non functional state, 100%
> of things will fail, and not have people approve things that can't pass?
> These kind of issues are the ones that make me uncomfortable with the
> Glance team taking on more mission until basic review hygiene is under
> control for the existing code.
>
> 	-Sean
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140823/d7fcaf04/attachment.html>