[openstack-dev] [all] new testtools breaking gate

Flavio Percoco flavio at redhat.com
Fri Aug 22 17:49:09 UTC 2014

On 08/22/2014 05:30 PM, Duncan Thomas wrote:
> At least for glance, the tox fix and the double setup problem are both
> blocking the gate, so it isn't possible to fix cleanly, since both
> issues need to be fixed in one commit - I think the correct thing is
> to merge https://review.openstack.org/#/c/116267/ and give projects
> time to fix up their issues cleanly.

We merged both fixes in a single patch. Once this[0] patch lands, glance
shouldn't be blocked by any of these 2 issues anymore.

[0] https://review.openstack.org/#/c/109749/


> On 22 August 2014 13:55, Ihar Hrachyshka <ihrachys at redhat.com> wrote:
> Hi all,
> this week is quite bumpy for unit testing in gate. First, it was
> upgrade to new 'tox' version that broke quite some branches.
> And today new testtools 0.9.36 were released and were caught by gate,
> which resulted in the following unit test failures in multiple projects:
> TestCase.setUp was already called. Do not explicitly call setUp from
> your tests. In your own setUp, use super to call the base setUp.
> All branches are affected: havana, icehouse, and master.
> This is because the following check was released with the new version
> of the library:
> https://github.com/testing-cabal/testtools/commit/5c3b92d90a64efaecdc4010a98002bfe8b888517
> And the temporary fix is to merge the version pin patch in global
> requirements, backport it to stable branches, and merge the updates
> from Openstack Proposal Bot to all affected projects. The patch for
> master requirements is: https://review.openstack.org/#/c/116267/
> In the meantime, projects will need to fix their tests not to call
> setUp() and tearDown() twice. This will be the requirement to unpin
> the version of the library.
> So, please review, backport, and make sure it lands in project
> requirements files.
> /Ihar
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Flavio Percoco

More information about the OpenStack-dev mailing list