[openstack-dev] [all] new testtools breaking gate

Ihar Hrachyshka ihrachys at redhat.com
Fri Aug 22 13:26:09 UTC 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

UPD: probably pinning the version is really overkill here, and instead
we should fix affected branches. Among them: Havana for neutron,
Havana+Icehouse+Juno for Glance. Other projects may also be affected.

For Neutron, it should be handled by the following backport:
https://review.openstack.org/116271

/Ihar

On 22/08/14 14:55, Ihar Hrachyshka wrote:
> Hi all,
> 
> this week is quite bumpy for unit testing in gate. First, it was 
> upgrade to new 'tox' version that broke quite some branches.
> 
> And today new testtools 0.9.36 were released and were caught by
> gate, which resulted in the following unit test failures in
> multiple projects:
> 
> TestCase.setUp was already called. Do not explicitly call setUp
> from your tests. In your own setUp, use super to call the base
> setUp.
> 
> All branches are affected: havana, icehouse, and master.
> 
> This is because the following check was released with the new
> version of the library: 
> https://github.com/testing-cabal/testtools/commit/5c3b92d90a64efaecdc4010a98002bfe8b888517
>
>  And the temporary fix is to merge the version pin patch in global 
> requirements, backport it to stable branches, and merge the
> updates from Openstack Proposal Bot to all affected projects. The
> patch for master requirements is:
> https://review.openstack.org/#/c/116267/
> 
> In the meantime, projects will need to fix their tests not to call 
> setUp() and tearDown() twice. This will be the requirement to
> unpin the version of the library.
> 
> So, please review, backport, and make sure it lands in project 
> requirements files.
> 
> /Ihar
> 
> _______________________________________________ OpenStack-dev
> mailing list OpenStack-dev at lists.openstack.org 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)

iQEcBAEBCgAGBQJT90TxAAoJEC5aWaUY1u57no0IAM4XUubdTyQB4siJuUSYZSFi
k3ZtgydQtdXq8hAWEUMTKqlU4hN+0qRJHK8jhXJraOfWj1KPIyzmJkZQg5UGp7WZ
aIlQiQGv2BcqPf+LoGX0QVOcrZWgHpB05iE3iCBOoPJmZeGX/iGG+xV7UVwI/ekV
JwjIp6SAJB4IfS3+S4rB3KUKuDx1XDBqFz40aPA7LTXNBvkQq8Xjiy0K+bb7/YC/
n7R7OUCqvbYgSQRKEADbKlFMCCl7Z1lV4XIcwHL4/cvImZxVGhl3V8rY9dTiE/cE
MVdZvXWZOKRVjfZxewbqT//v96jYGX1/v+RkmP85Vq9O2HW4VV5lwK8vjxLsA7k=
=XSGB
-----END PGP SIGNATURE-----



More information about the OpenStack-dev mailing list