On 21/08/14 18:05, Matthew Booth wrote: [snip] > This seems to mean different things to different people. There's a list > here which contains some criteria for new commits: [snip] > Any more of these? There is also https://wiki.openstack.org/wiki/CodeReviewGuidelines -- Radomir Dopieralski