Open Stack

On 8/12/2014 1:53 PM, Ihar Hrachyshka wrote:
> On 12/08/14 17:12, Henry Gessau wrote:
>> On 8/12/2014 10:27 AM, Ihar Hrachyshka wrote:
>>> as per [1], Cisco Nexus ML2 plugin requires a patched version of 
>>> ncclient from github. I wonder:
>>>
>>> - - whether this information is still current;
>>
>> Please see: https://review.openstack.org/112175
>>
>> But we need to do backports before updating the wiki.
> 
> Thanks for the link!
> 
>>
>>> - - why don't we depend on ncclient thru our requirements.txt
>>> file.
>>
>> Do we want to have requirements on things that are only used by a
>> specific vendor plugin? So far it has worked by vendor-specific
>> documentation instructing to manually install the requirement, or
>> vendor-tailored deployment tools/scripts.
>>
> 
> In downstream, it's hard to maintain all plugin dependencies if they
> are not explicitly mentioned in e.g. requirements.txt. Red Hat ships
> those plugins (with no commercial support or testing done on our
> side), and we didn't know that to make the plugin actually useable, we
> need to install that ncclient module until a person from Cisco
> reported the issue to us. We don't usually monitor random wiki pages
> to get an idea what we need to package and depend on. :)
> 
> I think we should have every third party module that we directly use
> in requirements.txt. We have code in the tree that imports ncclient
> (btw is it unit tested?), so I think it's enough to make that

The unit tests mock the import of ncclient.

> dependency explicit.
> 
> Now, maybe putting the module into requirements.txt is an overkill
> (though I doubt it). In that case, we could be interested in getting
> the info in some other centralized way.

I am not familiar with "other ways", but let me know if I can be of any help.

Note: it seems that the Brocade plugin also imports ncclient.