[openstack-dev] [oslo] oslo.concurrency repo review

Ben Nemec openstack at nemebean.com
Thu Aug 7 21:07:06 UTC 2014


LGTM.  Plenty of things I could add to your list, but they're all
post-import. :-)

-Ben

On 08/07/2014 01:58 PM, Yuriy Taraday wrote:
> Hello, oslo cores.
> 
> I've finished polishing up oslo.concurrency repo at [0] - please take a
> look at it. I used my new version of graduate.sh [1] to generate it, so
> history looks a bit different from what you might be used to.
> 
> I've made as little changes as possible, so there're still some steps left
> that should be done after new repo is created:
> - fix PEP8 errors H405 and E126;
> - use strutils from oslo.utils;
> - remove eventlet dependency (along with random sleeps), but proper testing
> with eventlet should remain;
> - fix for bug [2] should be applied from [3] (although it needs some
> improvements);
> - oh, there's really no limit for this...
> 
> I'll finalize and publish relevant change request to openstack-infra/config
> soon.
> 
> Looking forward to any feedback!
> 
> [0] https://github.com/YorikSar/oslo.concurrency
> [1] https://review.openstack.org/109779
> [2] https://bugs.launchpad.net/oslo/+bug/1327946
> [3] https://review.openstack.org/108954
> 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 




More information about the OpenStack-dev mailing list