[openstack-dev] [neutron] Neutron BP review process for Juno

Carl Baldwin carl at ecbaldwin.net
Thu Apr 17 19:18:22 UTC 2014


Wow, easiest merge ever!  Can we get this repository counted in our stats?!  ;)

Carl

On Thu, Apr 17, 2014 at 1:09 PM, Kyle Mestery <mestery at noironetworks.com> wrote:
> On Thu, Apr 17, 2014 at 1:18 PM, Carl Baldwin <carl at ecbaldwin.net> wrote:
>> Sure thing [1].  The easiest change I saw was to remove the
>> restriction that the number of sub titles is exactly 9.  This won't
>> require any of the other blueprints already posted for review to
>> change.  See what you think.
>>
> This was a good change, and in fact it's already been merged. Thanks!
>
> Kyle
>
>> Carl
>>
>> [1] https://review.openstack.org/#/c/88381/
>>
>> On Wed, Apr 16, 2014 at 3:43 PM, Kyle Mestery <mestery at noironetworks.com> wrote:
>>> On Wed, Apr 16, 2014 at 4:26 PM, Carl Baldwin <carl at ecbaldwin.net> wrote:
>>>> Neutron (and Nova),
>>>>
>>>> I have had one thing come up as I've been using the template.  I find
>>>> that I would like to add just a little document structure in the form
>>>> of a sub-heading or two under the "Proposed change" heading but before
>>>> the required "Alternatives" sub-heading.  However, this is not allowed
>>>> by the tests.
>>>>
>>>> Proposed change
>>>> =============
>>>>
>>>> I want to add a little bit of document structure here but I cannot
>>>> because any sub-headings would be counted among the exactly 9
>>>> sub-headings I'm required to have starting with "Alternatives".  This
>>>> seems a bit unnatural to me.
>>>>
>>>> Alternatives
>>>> ------------
>>>> ...
>>>>
>>>>
>>>> The sub-headings allow structure underneath but the first heading
>>>> doesn't.  Could be do it a little bit differentely?  Maybe something
>>>> like this?
>>>>
>>>> Proposed change
>>>> =============
>>>>
>>>> Overview
>>>> --------
>>>>
>>>> I could add structure under here.
>>>>
>>>> Alternatives
>>>> ------------
>>>> ...
>>>>
>>>> Thoughts?  Another idea might be to change the test to require at
>>>> least the nine required sub-headings but allow for the addition of
>>>> another.
>>>>
>>> I'm fine with either of these proposed changes to be honest. Carl,
>>> please submit a patch to neutron-specs and we can review it there.
>>>
>>> Also, I'm in the process of adding some jenkins jobs for neutron-specs
>>> similar to nova-specs.
>>>
>>> Thanks,
>>> Kyle
>>>
>>>> Carl
>>>>
>>>> On Tue, Apr 15, 2014 at 4:07 PM, Kyle Mestery <mestery at noironetworks.com> wrote:
>>>>> Given the success the Nova team has had in handling reviews using
>>>>> their new nova-specs gerrit repository, I think it makes a lot of
>>>>> sense for Neutron to do the same. With this in mind, I've added
>>>>> instructions to the BP wiki [1] for how to do. Going forward in Juno,
>>>>> this is how Neutron BPs will be handled by the Neutron core team. If
>>>>> you are currently working on a BP or code for Juno which is attached
>>>>> to a BP, please file the BP using the process here [1].
>>>>>
>>>>> Given this is our first attempt at using this for reviews, I
>>>>> anticipate there may be a few hiccups along the way. Please reply on
>>>>> this thread or reach out in #openstack-neutron and we'll sort through
>>>>> whatever issues we find.
>>>>>
>>>>> Thanks!
>>>>> Kyle
>>>>>
>>>>> [1] https://wiki.openstack.org/wiki/Blueprints#Neutron
>>>>>
>>>>> _______________________________________________
>>>>> OpenStack-dev mailing list
>>>>> OpenStack-dev at lists.openstack.org
>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>
>>>> _______________________________________________
>>>> OpenStack-dev mailing list
>>>> OpenStack-dev at lists.openstack.org
>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>> _______________________________________________
>>> OpenStack-dev mailing list
>>> OpenStack-dev at lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list