[openstack-dev] [neutron] Neutron BP review process for Juno
trinath.somanchi at freescale.com
trinath.somanchi at freescale.com
Wed Apr 16 16:05:21 UTC 2014
Hi Mestery
With respect to the new BP review process, can we start submitting the BPs in the review system and in the launchpad.
Since, BP is a thought process of the developer either for core dev or for vendor specific dev,
can you give some light on how the review process of the BP can be ?
asciiflow.com is a best tool for showing the pictorial representation of the BP work. Thank you for the link..
Were there any variations in general code review processes.
-
Trinath
________________________________________
From: Kyle Mestery <mestery at noironetworks.com>
Sent: Wednesday, April 16, 2014 7:22 PM
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [neutron] Neutron BP review process for Juno
Actually, +1 to that Salvatore! I've found asciiflow.com to be superb
for these types of things.
On Wed, Apr 16, 2014 at 8:39 AM, Salvatore Orlando <sorlando at nicira.com> wrote:
> if the image you're adding is a diagram, I would think about asciiflow.com
> first!
>
>
> On 16 April 2014 15:09, Kyle Mestery <mestery at noironetworks.com> wrote:
>>
>> I think the problem is that your spec should be at the toplevel of the
>> juno directory, and that's why the UT is failing. Can you move your
>> spec up a level, including the image? You can create a spec images
>> directory to put them in there and reference it in the spec as well if
>> you want.
>>
>> On Tue, Apr 15, 2014 at 11:48 PM, Sumit Naiksatam
>> <sumitnaiksatam at gmail.com> wrote:
>> > What's the convention for adding images to the patch? The following
>> > directory structure seemed logical to me (but the current UT will not
>> > allow it):
>> >
>> > specs/juno/<bp-name>/<bp-name>.rst
>> > specs/juno/<bp-name>/images/<image1>.png
>> >
>> > Thanks,
>> > ~Sumit.
>> >
>> >
>> >
>> > On Tue, Apr 15, 2014 at 3:35 PM, Carl Baldwin <carl at ecbaldwin.net>
>> > wrote:
>> >> +1. I think we'll like this process better. I hope to have some of
>> >> the first blueprints to propose to the new repository very soon.
>> >>
>> >> On Tue, Apr 15, 2014 at 4:07 PM, Kyle Mestery
>> >> <mestery at noironetworks.com> wrote:
>> >>> Given the success the Nova team has had in handling reviews using
>> >>> their new nova-specs gerrit repository, I think it makes a lot of
>> >>> sense for Neutron to do the same. With this in mind, I've added
>> >>> instructions to the BP wiki [1] for how to do. Going forward in Juno,
>> >>> this is how Neutron BPs will be handled by the Neutron core team. If
>> >>> you are currently working on a BP or code for Juno which is attached
>> >>> to a BP, please file the BP using the process here [1].
>> >>>
>> >>> Given this is our first attempt at using this for reviews, I
>> >>> anticipate there may be a few hiccups along the way. Please reply on
>> >>> this thread or reach out in #openstack-neutron and we'll sort through
>> >>> whatever issues we find.
>> >>>
>> >>> Thanks!
>> >>> Kyle
>> >>>
>> >>> [1] https://wiki.openstack.org/wiki/Blueprints#Neutron
>> >>>
>> >>> _______________________________________________
>> >>> OpenStack-dev mailing list
>> >>> OpenStack-dev at lists.openstack.org
>> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >>
>> >> _______________________________________________
>> >> OpenStack-dev mailing list
>> >> OpenStack-dev at lists.openstack.org
>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> >
>> > _______________________________________________
>> > OpenStack-dev mailing list
>> > OpenStack-dev at lists.openstack.org
>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
More information about the OpenStack-dev
mailing list