[openstack-dev] Dropping or weakening the 'only import modules' style guideline - H302

Duncan Thomas duncan.thomas at gmail.com
Wed Apr 9 19:44:25 UTC 2014


On 6 August 2013 21:18, Christopher Armstrong
<chris.armstrong at rackspace.com> wrote:

> I think it's really unfortunate that people will block patches based on
> stylistic concerns. The answer, IMO, is to codify in policy that stylistic
> issues *cannot* block a patch from landing.

It think the problems here are:
(a) death by a thousand cuts - code that has many tiny stylistic
differences is harder to read, harder to reason about and harder to
get correct
(b) if the existing code is of highest possible quality, it sets the
bar for incoming code. Requiring new code to be significantly better
than the old code just makes new contributors resentful.



More information about the OpenStack-dev mailing list