[openstack-dev] [Ironic] March core team review

Devananda van der Veen devananda.vdv at gmail.com
Tue Apr 8 15:25:30 UTC 2014


As March has come to a close, and Juno is open for development, I would
like to look at our review stats and see if the core review team should be
adjusted to reflect current activity. Also, since I believe that our
development pace needs to accelerate, I would like to increase the size of
the team from its current size of six.

As a quick outline of what "core" means within this team: in my view, it's
a combination of how active and effective someone's reviews are, and how
much they participate in relevant discussions. Ideally, cores should aim
for about two reviews per work day, or about 40 per month, but it's not a
hard limit, and I don't believe we should remove folks simply because their
review stats slip below this line if their input is still felt and valued
within the project.

With ~160 reviews submitted in the last month, in an ideal situation, we
would be able to keep up with submissions if we had a review team size of 8
(since it takes a minimum of two cores to land a patch). Given that reviews
have been taking an average of 2.8 patch sets, we would actually fall
behind if reviewers didn't do more than 2/day - and for a large part of
Icehouse, we were pretty far behind... For this reason, reviews by non-core
members are extremely helpful because they often catch issues early and
allow core reviewers to focus on patches that have already received some
+1's.

Here are the current 90-day stats, cut at the point where folks are meeting
the suggested quantity of reviews.

http://russellbryant.net/openstack-stats/ironic-reviewers-90.txt

+--------------------+---------------------------------------+----------------+
|      Reviewer      | Reviews   -2  -1  +1  +2  +A    +/- % |
Disagreements* |
+--------------------+---------------------------------------+----------------+
|    devananda **    |     358   22 101   7 228 132    65.6% |   10 (
2.8%)  |
|   lucasagomes **   |     316    4  99   4 209  61    67.4% |    8 (
2.5%)  |
|    nobodycam **    |     199    0  24   0 175  81    87.9% |   11 (
5.5%)  |
|        rloo        |     180    0  74 106   0   0    58.9% |    8 (
4.4%)  |
|       whaom        |     153    0  56  97   0   0    63.4% |   15 (
9.8%)  |
|       yuriyz       |     136    0  57  79   0   0    58.1% |   14 (
10.3%)  |
|    max_lobur **    |     131    1  44  38  48   4    65.6% |    7 (
5.3%)  |

So, I'd like to formally propose that Ruby (rloo), Haomeng (whaom), and
Yuriy (yuriyz) be added to the core team at this time. I believe they have
all been very helpful over the last few months.

Regards,
Devananda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140408/95ec0ac8/attachment.html>


More information about the OpenStack-dev mailing list