[openstack-dev] [TripleO] reviewer update march

Tomas Sedovic tsedovic at redhat.com
Thu Apr 3 14:48:11 UTC 2014


On 03/04/14 13:02, Robert Collins wrote:
> Getting back in the swing of things...
> 
> Hi,
>     like most OpenStack projects we need to keep the core team up to
> date: folk who are not regularly reviewing will lose context over
> time, and new folk who have been reviewing regularly should be trusted
> with -core responsibilities.
> 
> In this months review:
>  - Dan Prince for -core
>  - Jordan O'Mara for removal from -core
>  - Jiri Tomasek for removal from -core
>  - Jamomir Coufal for removal from -core
> 
> Existing -core members are eligible to vote - please indicate your
> opinion on each of the three changes above in reply to this email.

+1

> 
<snip>
> 
> 
> -core that are not keeping up recently... :
> 
> |       tomas-8c8 **      |      31    0   4   2  25   8    87.1% |

Duly noted. I've picked up the daily pace again in the last couple of
weeks and will continue doing so.

> 1 (  3.2%)  |
> |        marios **        |      27    0   1  17   9   7    96.3% |
> 3 ( 11.1%)  |
> |       tzumainn **       |      27    0   3  23   1   4    88.9% |
> 0 (  0.0%)  |
> |        pblaho **        |      17    0   0   4  13   4   100.0% |
> 1 (  5.9%)  |
> |        jomara **        |       0    0   0   0   0   1     0.0% |
> 0 (  0.0%)  |
> 
> 
> Please remember - the stats are just an entry point to a more detailed
> discussion about each individual, and I know we all have a bunch of
> work stuff, on an ongoing basis :)
> 
> I'm using the fairly simple metric we agreed on - 'average at least
> three reviews a
> day' as a proxy for 'sees enough of the code and enough discussion of
> the code to be an effective reviewer'. The three review a day thing we
> derived based
> on the need for consistent volume of reviews to handle current
> contributors - we may
> lower that once we're ahead (which may happen quickly if we get more cores... :)
> But even so:
>  - reading three patches a day is a pretty low commitment to ask for
>  - if you don't have time to do that, you will get stale quickly -
> you'll only see under
>    33% of the code changes going on (we're doing about 10 commits
>    a day - twice as many since december - and hopefully not slowing down!)
> 
> Cheers,
> Rob
> 
> 




More information about the OpenStack-dev mailing list