Open Stack

On 04/02/2014 11:05 AM, Ana Krivokapic wrote:
> On 04/02/2014 07:36 PM, Dougal Matthews wrote:
>>
>>
>> On my phone so I can't follow this up more now, but it looks like
>> JSHint is already used.
>>
>> https://review.openstack.org/#/c/41087/
>>
>
> That commit has since been reverted and JSHint removed from Horizon
> codebase:
> https://bugs.launchpad.net/horizon/+bug/1270764
> https://review.openstack.org/#/c/68268/
>
> Seems like there's some controversy around whether the licenses are
> actually incompatible or not. How do we go about clearing that up? :)
>

I was a little unclear before.

Two things:

- We should use the same stuff we've put together for storyboard

- It is not needed to include jshint in the codebase to be able to use it

To expand on the second point - we've found tooling to allow us to 
integrate things like jshint into python virtualenv (just go ahead and 
be amazed) So it's entirely possible to do _ALL_ of this in a way that 
is consistent with how we work in OpenStack. Check out these two patches 
to zuul:

https://review.openstack.org/#/c/82307/
https://review.openstack.org/#/c/82308/

Which show incorporating it into a standing python project. If I get a 
chance this weekend - I can try to cook up a similar one for 
horizon/tuskar if nobody beats me to it.