Open Stack

On 2013-09-20 03:16, Flavio Percoco wrote:
> On 19/09/13 17:10 -0400, Adam Young wrote:
>> On 09/19/2013 04:30 PM, Mark McLoughlin wrote:
>>> To take the specific example of the policy API, if someone actively
>>> wanted to help the process of moving it into a standalone library 
>>> should
>>> volunteer to help Flavio out as a maintainer:
>>> 
>>>   
>>>  
>>>  
>>>  
>>> ps://git.openstack.org/cgit/openstack/oslo-incubator/tree/MAINTAINERS
>>> 
>>>   == policy ==
>>> 
>>>   M: Flavio Percoco <flavio at redhat.com>
>>>   S: Maintained
>>>   F: policy.py
>> 
>> Would it make sense to explicitly add Keystone developers, or can we 
>> include the launchpad keystone-core group to this module?
>> If we want to keep it per user,  I'm willing to do so, and I think we 
>> have a couple of other likely candidates from Keystone:  I'll let then 
>> speak up for themselves.
>> 
> I don't think it is possible to have per-file core reviewers.

Not from a Gerrit perspective, but the Oslo policy is that a maintainer 
+1 on the code they maintain is the equivalent of a +2, so only one core 
is needed to approve.

See 
https://github.com/openstack/oslo-incubator/blob/master/MAINTAINERS#L28

-Ben