[openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

Chris Friesen chris.friesen at windriver.com
Thu Oct 31 17:07:14 UTC 2013


On 10/31/2013 06:04 AM, Rosa, Andrea (HP Cloud Services) wrote:

>> A - there is no test suite at all, adding one in unreasonable B - this thing cannot
>> be tested in this context (e.g. functional tests are defined in a different tree)
>> C - this particular thing is very hard to test
 >> D - testing this won't offer benefit

> In my opinion  C instead of being an acceptable reason for not having tests is a symptom of one of the two things:
> 1) F => Submitter doesn't know how to write tests, in this case someone else can help with suggestions
> 2) The code we are trying to test is too complicated so it's time to refactor it
>
> And about D, In my opinion  tests always offer benefits, like code coverage or helping in understanding the code.

I think there are actually cases where C is valid.  It's difficult to 
test certain kinds of race conditions, for example, unless you have very 
low-level hooks into the guts of the system in order to force the 
desired conditions to reliably occur at exactly the right time.

Chris




More information about the OpenStack-dev mailing list