[openstack-dev] [nova] changing old migrations is verboten
Jay Pipes
jaypipes at gmail.com
Thu Oct 31 15:23:26 UTC 2013
On 10/31/2013 08:01 AM, Sean Dague wrote:
> So there is a series of patches starting with -
> https://review.openstack.org/#/c/53417/ that go back and radically
> change existing migration files.
>
> This is really a no-no, unless there is a critical bug fix that
> absolutely requires it. Changing past migrations should be considered
> with the same level of weight as an N-2 backport, only done when there
> is huge upside to the change.
>
> I've -2ed the first 2 patches in the series, though that review applies
> to all of them (I figured a mailing list thread was probably more useful
> than -2ing everything in the series).
>
> There needs to be really solid discussion about the trade offs here
> before contemplating something as dangerous as this.
+1
-jay
More information about the OpenStack-dev
mailing list