Open Stack

Hi,

I have updates on my work towards getting Horizon updated to Bootstrap 3.

I have finished Bootstrap 3 update for Horizon using the old lessc 
compiler to review the work and I have created two versions:
1. patch that uses original lessc library to be able to review the 
bootstrap 3 in current Horizon [1]
2. patch that uses Lesscpy but does not compile css properly - for 
reviewing of the compilation issues [2]
(see commit messages for details)

I marked these as work in progress because of lesscpy problems but 
please feel free to have a look and give feedback.

So what is remaining is to get lesscpy up to speed with Bootstrap 3. 
Sascha Peilicke has created a fix to "support semicolons in mixin 
arguments" [3] some time agobut it still needs to get into original 
repository as pull request. The other issues reported are still valid. 
Buggest issue at the moment seems to be in @media declaration including 
variable <https://github.com/robotis/Lesscpy/issues/18>[4]. I have tried 
to have a look at this but the solution is probably not the best... [5]. 
I have contacted Sascha regarding this and so far I am waiting for response.

Any feedback or help with getting Lesscpy fixed is highly welcome.

[1] https://review.openstack.org/#/c/49710/
[2] https://review.openstack.org/#/c/49712/
[3] https://github.com/saschpe/Lesscpy/commits/master
[4] https://github.com/robotis/Lesscpy/issues/18
[5] https://github.com/jtomasek/Lesscpy/commits/var_in_media

Thanks

Jirka


On 09/19/2013 01:44 AM, Gabriel Hurley wrote:
> I'm also strongly against reverting the move to lesscpy. As David said, that change was highly-requested by the downstream distros and other folks packaging Horizon in various ways.
>
> Since there's no evidence that lesscpy does not intend to support bootstrap 3 in a reasonable timeframe, reverting the patch in the interim would simply be impatience. The better thing to do as a member of the larger open source community is to contribute your own energy to lesscpy and to help them improve their project in a timely manner. I'm glad to hear that Sasha is already working on that. I'm sure they're happy for the assistance and for having their work utilized by a significant project like Horizon.
>
> We'll get to bootstrap 3, but not by undoing work we've already done.
>
> Please keep us all updated on the progress upstream, I know I for one look forward to seeing the benefits we can derive from the newer bootstrap code.
>
>      - Gabriel
>
>> -----Original Message-----
>> From: Lyle, David (Cloud Services) [mailto:david.lyle at hp.com]
>> Sent: Wednesday, September 18, 2013 8:44 AM
>> To: OpenStack Development Mailing List
>> Subject: Re: [openstack-dev] [Horizon] Bootstrap 3 update and problems
>> with lesscpy
>>
>> Right now, master in Horizon is still working toward Havana-rc1.  We are still
>> likely more than a week away from master moving to Icehouse-1.  As this is
>> the case, reverting a highly desired Havana change to address a blueprint for
>> Icehouse that can be addressed properly upstream in lesscpy does not seem
>> like a good course of action.  I understand the amount of work involved in
>> updating Bootstrap, but our goal should be to properly resolve the conflict
>> once we are working on Icehouse.
>>
>> -David
>>
>> On Wednesday, September 18, 2013 6:27 AM Jiri Tomasek
>> [mailto:jtomasek at redhat.com] wrote:
>>
>>> Hi all,
>>> I've started working on updating Bootstrap to version 3 in Horizon.
>> https://blueprints.launchpad.net/horizon/+spec/bootstrap-update
>>
>>> As I have described in blueprint whiteboard, I am experiencing compile
>> problems with the new lesscpy compiler that we started using recently. The
>> compiled css code is incorrect and when running the compilation from
>> terminal, about 200 syntax errors occur. This is related to certain features of
>> Less not being supported by lesscpy. I have created a GIthub issue for
>> lesscpy here: https://github.com/robotis/Lesscpy/issues/22 .
>>
>>> Sasha Peilicke has already started working on updating the lesscpy library to
>> support all less features needed to compile Bootstrap 3 properly. Although I
>> think that it will take more than a few weeks before lesscpy is there where
>> we need it.
>>
>>> I have part of Bootstrap 3 update ready and as it is quite a large patch I
>> would like to get this in as soon as possible because any rebase to a new
>> Horizon master is quite tedious process. Also there are another blueprints
>> that depend on this update (font-icons and css-breakdown, see dependency
>> tree).
>>
>>> So I would like to propose to revert the patch that introduces lesscpy library
>> (a0739c9423 Drop NodeJS dependency in favor of pure-python lesscpy) and
>> use the lessc library for the time being untill lesscpy is capable of compiling
>> Bootstrap 3.
>>
>>> I have revert patch ready together with update of lessc library in
>> horizon/bin, which I can make part of Bootstrap-update blueprint and send
>> them right away to gerrit for a review. I have also tested that with this >
>> setup the Bootstrap 3 updated Horizon less file compiles properly.
>>
>>> When lesscpy is ready to support Bootstrap 3, geting back to lesscpy is then
>> simple process of just reapplying the reverted commit.
>>
>>> -- Jirka Tomasek
>>
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131022/8e2777d6/attachment.html>