Open Stack

Running "git review -d $gerrit_id" will download the patch and create a
local branch for you.

For example, if I wanted to work on Sandy's patch
https://review.openstack.org/#/c/51249 I would "git review -d 51249". I can
then amend the changeset, rebase, or whatever. Running "git review" will
push it up to gerrit again, and as long as I leave the Change-Id in the
commit message intact, gerrit will add a new patchset to the existing
review.

One small procedural suggestion: Leave a comment on the review to minimize
race conditions with other reviewers who are also considering providing
fixes.




On Fri, Oct 11, 2013 at 2:46 PM, David Kranz <dkranz at redhat.com> wrote:

> On 10/11/2013 02:34 PM, Clint Byrum wrote:
>
>> Recently in the TripleO meeting we identified situations where we need
>> to make it very clear that it is ok to pick up somebody else's patch
>> and finish it. We are broadly distributed, time-zone-wise, and I know
>> other teams working on OpenStack projects have the same situation. So
>> when one of us starts the day and sees an obvious issue with a patch,
>> we have decided to take action, rather than always -1 and move on. We
>> clarified for our core reviewers that this does not mean that now both
>> of you cannot +2. We just need at least one person who hasn't been in
>> the code to also +2 for an approval*.
>>
>> I think all projects can benefit from this model, as it will raise
>> velocity. It is not perfect for everything, but it is really great when
>> running up against deadlines or when a patch has a lot of churn and thus
>> may take a long time to get through the "rebase gauntlet".
>>
>> So, all of that said, I want to encourage all OpenStack developers to
>> say "thanks for fixing my patch" when somebody else does so. It may seem
>> obvious, but publicly expressing gratitude will make it clear that you
>> do not take things personally and that we're all working together.
>>
>> Thanks for your time -Clint
>>
>> * If all core reviewers have been in on the patch, then any two +2's
>> work.
>>
>> ______________________________**_________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.**org <OpenStack-dev at lists.openstack.org>
>> http://lists.openstack.org/**cgi-bin/mailman/listinfo/**openstack-dev<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>>
> Thanks, Clint. I have wanted to do this in the past but was not sure how.
> Can you provide the steps to take over some one else's patch and submit it?
> I volunteer to add it to https://wiki.openstack.org/**wiki/Gerrit_Workflow<https://wiki.openstack.org/wiki/Gerrit_Workflow>
> .
>
>  -David
>
>
> ______________________________**_________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.**org <OpenStack-dev at lists.openstack.org>
> http://lists.openstack.org/**cgi-bin/mailman/listinfo/**openstack-dev<http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131011/4ec33483/attachment.html>