Open Stack

On Fri, Nov 22, 2013 at 11:24 AM, Duncan Thomas <duncan.thomas at gmail.com>wrote:

> On 22 November 2013 14:59, Ben Nemec <openstack at nemebean.com> wrote:
>
> > One other thought I had was to add the ability to split one Oslo sync up
> > into multiple commits, either one per module, or even one per Oslo commit
> > for some really large module changes (I'm thinking of the 1000 line db
> sync
> > someone mentioned recently).  It would be more review churn, but at
> least it
> > would keep the changes per review down to a more reasonable level.   I'm
> not
> > positive it would be beneficial, but I thought I'd mention it.
>
> Cinder (often but not always me) tends to reject merges that do more
> that one module at a time, because it makes it far harder to review
> and spot problems, so some from of automation of this would be great.
>

There are times when the commits are related, but in general this seems
like a good practice.

Doug



>
> --
> Duncan Thomas
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131122/6f52850e/attachment.html>