Open Stack

Greetings,

We now have some numbers we can look at for how long people are waiting
for code reviews.  What kind of turnaround time should we be aiming for?

5 days?

The current data is below for reference.  Note that the numbers are a
good bit different than what I posted yesterday.  The numbers yesterday
included stable branch commits.  The script no longer includes those by
default (thanks to cyeoh for pointing this out).

$ for project in *.json ; do ./openreviews.py -p ${project} && echo ; done
Projects: [u'cinder']
Total Open Reviews: 37
Waiting on Submitter: 16
Waiting on Reviewer: 21
 --> Average wait time: 2 days, 12 hours, 8 minutes
 --> Median wait time: 0 days, 16 hours, 29 minutes
 --> Number waiting more than 7 days: 3
 --> Longest waiting reviews:
    --> 5 days, 23 hours, 40 minutes https://review.openstack.org/30226
          (Editable default quota support for cinder)
    --> 6 days, 20 hours, 13 minutes https://review.openstack.org/30137
          (Set the correct location for the tests.)
    --> 7 days, 7 hours, 45 minutes https://review.openstack.org/29829
          (Client side of shares service in Cinder.)
    --> 9 days, 5 hours, 14 minutes https://review.openstack.org/28947
          (Implement scheduler hints for APIv2)
    --> 9 days, 22 hours, 55 minutes https://review.openstack.org/29709
          (Make ManagerWithFind abstract and fix its descendants)

Projects: [u'glance']
Total Open Reviews: 26
Waiting on Submitter: 6
Waiting on Reviewer: 20
 --> Average wait time: 3 days, 9 hours, 41 minutes
 --> Median wait time: 2 days, 12 hours, 46 minutes
 --> Number waiting more than 7 days: 3
 --> Longest waiting reviews:
    --> 5 days, 1 hours, 44 minutes https://review.openstack.org/29405
          (Fix for unencrypted uris in scrubber queue files)
    --> 6 days, 5 hours, 8 minutes https://review.openstack.org/30069
          (Update importutils and openstack-common.conf format)
    --> 7 days, 20 hours, 55 minutes https://review.openstack.org/27491
          (Prevent '500' error when admin uses private marker)
    --> 7 days, 23 hours, 34 minutes https://review.openstack.org/29297
          (Add policies for membership APIs)
    --> 13 days, 21 hours, 49 minutes https://review.openstack.org/27601
          (Add qpid-python to test-requires)

Projects: [u'heat']
Total Open Reviews: 22
Waiting on Submitter: 7
Waiting on Reviewer: 15
 --> Average wait time: 3 days, 13 hours, 1 minutes
 --> Median wait time: 0 days, 13 hours, 44 minutes
 --> Number waiting more than 7 days: 2
 --> Longest waiting reviews:
    --> 5 days, 0 hours, 16 minutes https://review.openstack.org/30439
          (Add a separate Template class for the HOT format)
    --> 5 days, 4 hours, 52 minutes https://review.openstack.org/30405
          (engine : PoC initial template_format parser for HOT template)
    --> 5 days, 18 hours, 36 minutes https://review.openstack.org/27934
          (Translate basic template to HOT)
    --> 12 days, 21 hours, 51 minutes https://review.openstack.org/29400
          (Add CONTRIBUTING.rst file.)
    --> 20 days, 19 hours, 9 minutes https://review.openstack.org/28598
          (Add Heat DSL samples for WordPress_Single_Instance)

Projects: [u'keystone']
Total Open Reviews: 59
Waiting on Submitter: 26
Waiting on Reviewer: 33
 --> Average wait time: 10 days, 0 hours, 8 minutes
 --> Median wait time: 4 days, 18 hours, 59 minutes
 --> Number waiting more than 7 days: 12
 --> Longest waiting reviews:
    --> 9 days, 22 hours, 50 minutes https://review.openstack.org/29711
          (Disable eventlet monkey-patching of DNS)
    --> 9 days, 22 hours, 59 minutes https://review.openstack.org/29708
          (Make ManagerWithFind abstract and fix TokenManager)
    --> 12 days, 19 hours, 34 minutes https://review.openstack.org/23970
          (Move auth_token middleware from admin user to an RBAC policy)
    --> 60 days, 23 hours, 46 minutes https://review.openstack.org/25713
          (Test for backend case sensitivity)
    --> 124 days, 21 hours, 32 minutes https://review.openstack.org/20404
          (Use AuthRef for some client fields)

Projects: [u'nova']
Total Open Reviews: 164
Waiting on Submitter: 63
Waiting on Reviewer: 101
 --> Average wait time: 3 days, 16 hours, 27 minutes
 --> Median wait time: 2 days, 0 hours, 29 minutes
 --> Number waiting more than 7 days: 20
 --> Longest waiting reviews:
    --> 12 days, 22 hours, 10 minutes https://review.openstack.org/29396
          (Added unit tests for vmware cluster driver)
    --> 14 days, 16 hours, 22 minutes https://review.openstack.org/29156
          (Add the ability to query config values on remote compute nodes)
    --> 15 days, 2 hours, 17 minutes https://review.openstack.org/29077
          (Extract live-migration scheduler logic from the scheduler driver)
    --> 15 days, 17 hours, 24 minutes https://review.openstack.org/29005
          (Set resized instance back to original vm_state)
    --> 16 days, 10 hours, 47 minutes https://review.openstack.org/28921
          (Ports image_metaadata API to v3 API)

Projects: [u'oslo']
Total Open Reviews: 43
Waiting on Submitter: 17
Waiting on Reviewer: 26
 --> Average wait time: 6 days, 6 hours, 21 minutes
 --> Median wait time: 7 days, 4 hours, 59 minutes
 --> Number waiting more than 7 days: 13
 --> Longest waiting reviews:
    --> 8 days, 20 hours, 23 minutes https://review.openstack.org/29617
          (Add config for qpid durable/auto_delete queues)
    --> 8 days, 22 hours, 25 minutes https://review.openstack.org/29788
          (Use stubout in test_correlation_id)
    --> 9 days, 1 hours, 33 minutes https://review.openstack.org/29769
          (Fix tox coverange env)
    --> 9 days, 1 hours, 34 minutes https://review.openstack.org/29766
          (Use mox object from moxstubout fixture)
    --> 12 days, 19 hours, 37 minutes https://review.openstack.org/29416
          (Fix NoRootWrapSpecified when running nova-rpc-zmq-receiver)

Projects: [u'quantum']
Total Open Reviews: 63
Waiting on Submitter: 25
Waiting on Reviewer: 38
 --> Average wait time: 11 days, 8 hours, 23 minutes
 --> Median wait time: 5 days, 23 hours, 44 minutes
 --> Number waiting more than 7 days: 18
 --> Longest waiting reviews:
    --> 28 days, 5 hours, 10 minutes https://review.openstack.org/27136
          (Redefined status fields as enums.)
    --> 28 days, 22 hours, 22 minutes https://review.openstack.org/27818
          (Fix a race condition in add_tunnel_endpoint())
    --> 31 days, 6 hours, 26 minutes https://review.openstack.org/25025
          (Refactored parsing and detection of help arguments.)
    --> 60 days, 23 hours, 30 minutes https://review.openstack.org/25714
          (Fix unit test for shell outputs error message)
    --> 71 days, 1 hours, 52 minutes https://review.openstack.org/24776
          (Handle SSL certificates validation properly.)

Projects: [u'swift']
Total Open Reviews: 32
Waiting on Submitter: 12
Waiting on Reviewer: 20
 --> Average wait time: 4 days, 8 hours, 28 minutes
 --> Median wait time: 3 days, 3 hours, 11 minutes
 --> Number waiting more than 7 days: 3
 --> Longest waiting reviews:
    --> 5 days, 17 hours, 40 minutes https://review.openstack.org/22569
          (remove busy-wait so that swift client won't use up all CPU
cycles)
    --> 6 days, 2 hours, 47 minutes https://review.openstack.org/30258
          (add -l and -lh switches to swift list command)
    --> 9 days, 0 hours, 7 minutes https://review.openstack.org/20029
          (Add option to disable SSL compression)
    --> 15 days, 2 hours, 21 minutes https://review.openstack.org/27430
          (Implementation cross-region replication.)
    --> 15 days, 2 hours, 21 minutes https://review.openstack.org/27431
          (Implementation of proxy affinity for requests.)

Projects: [u'tempest']
Total Open Reviews: 27
Waiting on Submitter: 13
Waiting on Reviewer: 14
 --> Average wait time: 2 days, 0 hours, 51 minutes
 --> Median wait time: 1 days, 13 hours, 4 minutes
 --> Number waiting more than 7 days: 0
 --> Longest waiting reviews:
    --> 2 days, 2 hours, 14 minutes https://review.openstack.org/30608
          (Merged 2 tests dependent on each other)
    --> 2 days, 2 hours, 55 minutes https://review.openstack.org/28389
          (Fixes bugs in test_s3_ec2_images)
    --> 5 days, 0 hours, 40 minutes https://review.openstack.org/30438
          (Fix tools/skip_tracker.py to search tests in the "api" directory)
    --> 5 days, 18 hours, 8 minutes https://review.openstack.org/30330
          (Update skip_tracker test directory)
    --> 5 days, 21 hours, 16 minutes https://review.openstack.org/30271
          (Update a test to work with Quantum SecGroup)


$ ./openreviews.py -a
Projects: [u'nova', u'tempest', u'cinder', u'oslo', u'swift', u'heat',
u'glance', u'quantum', u'keystone']
Total Open Reviews: 473
Waiting on Submitter: 185
Waiting on Reviewer: 288
 --> Average wait time: 5 days, 12 hours, 13 minutes
 --> Median wait time: 3 days, 2 hours, 37 minutes
 --> Number waiting more than 7 days: 74
 --> Longest waiting reviews:
    --> 31 days, 6 hours, 27 minutes https://review.openstack.org/25025
          (Refactored parsing and detection of help arguments.)
    --> 60 days, 23 hours, 31 minutes https://review.openstack.org/25714
          (Fix unit test for shell outputs error message)
    --> 60 days, 23 hours, 47 minutes https://review.openstack.org/25713
          (Test for backend case sensitivity)
    --> 71 days, 1 hours, 53 minutes https://review.openstack.org/24776
          (Handle SSL certificates validation properly.)
    --> 124 days, 21 hours, 33 minutes https://review.openstack.org/20404
          (Use AuthRef for some client fields)


https://github.com/russellb/openstack-stats

-- 
Russell Bryant