Open Stack

Hi Avishay,

Thanks for uploading the patch. Please see my explained comments:

I think there's no need to remove original plugin since it does the job and
also it quite suits the goal of your "master blueprint".

*> The noop driver is used for testing purposes and may be a good starting
point for vendors who wish to implement their own driver.*
That ok then, but in such case I'd just move noop driver in unit test
directory.

*> Can you please elaborate about your patch - which BP is backing it?*
I was planning to submit my patch under your
"multi-vendor-support-for-lbaas<https://blueprints.launchpad.net/quantum/+spec/multi-vendor-support-for-lbaas>"
blueprint.
Btw, I think it's not necessary to have several separate BPs as steps could
be described as work items in the "master" blueprint.

So I've not submitted my patch yet because I was waiting for consensus
about some "house keeping" of services and lbaas dirs, see
https://bugs.launchpad.net/quantum/+bug/1175745
Making such change (renaming/moving) could add pain for those who maintain
uncommitted patches.
I think I'll post in on review shortly, in WIP state, just to show the idea.

Thanks,
Eugene.

On Sun, May 5, 2013 at 2:40 PM, Avishay Balderman (Code Review) <
review at openstack.org> wrote:

> Avishay Balderman has posted comments on this change.
>
> Change subject: BluePrint: multi-vendor-support-for-lbaas-step0
> ......................................................................
>
>
> Patch Set 1:
>
> Hi Eugene
> As you probably know this patch is "step0" of
> https://blueprints.launchpad.net/quantum/+spec/multi-vendor-support-for-lbaas
> .
> In the next step the original plugin will be removed and there will be
> only one lbaas plugin.
> The noop driver is used for testing purposes and may be a good starting
> point for vendors who wish to implement their own driver.
> Can you please elaborate about your patch - which BP is backing it?
>
> --
> To view, visit https://review.openstack.org/28245
> To unsubscribe, visit https://review.openstack.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Ic5b2c46c5a74338c3fa14cc991f4420cabd7798e
> Gerrit-PatchSet: 1
> Gerrit-Project: openstack/quantum
> Gerrit-Branch: master
> Gerrit-Owner: Avishay Balderman <avishayb at radware.com>
> Gerrit-Reviewer: Avishay Balderman <avishayb at radware.com>
> Gerrit-Reviewer: Jenkins
> Gerrit-Reviewer: enikanorov <enikanorov at mirantis.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130505/d3c1a05f/attachment.html>