[openstack-dev] [horizon] [*client] WAS [Openstack-stable-maint] Build failed in Jenkins: periodic-horizon-python27-stable-folsom #178

Julie Pichon jpichon at redhat.com
Fri Mar 29 14:36:00 UTC 2013


"Alan Pevec" <apevec at gmail.com> wrote:
> Hi all,
> 
> horizon stable/folsom started failing after keystoneclient 0.2.3 last
> good was
>  https://jenkins.openstack.org/job/periodic-horizon-python27-stable-folsom/168/
> with keystoneclient 0.2.2.
> 
> All OpenStack clients are supposed to be backward compatible, so I'm
> not sure if the solution here is to lock all client version on
> stable/* or is Horizon using keystoneclient internals which aren't
> part of stable API?

Hi Alan,

Thank you for bringing this up, I went and had a look. I don't think this is affecting functionality, but only the tests and mox in particular.

This is the keystoneclient commit that causes the problem:

https://github.com/openstack/python-keystoneclient/commit/01735608644a8b71d98f7798ccd6549e4db5de48

in which auth_token started using the @property decorator. Googling around, apparently mox is known not to behave very well with decorators.

This isn't happening on the Horizon master branch thanks to this commit, which explicitly mocks the auth_token:

https://github.com/openstack/horizon/commit/1e867700415b17c29056fb55069b6a3e2b22cf1b

I'm going to file a bug for the error Alan mentioned and backport that patch to Folsom. Let me know if that doesn't sound reasonable.

Cheers,

Julie

> Cheers,
> Alan
> 
> 
> 2013/3/28 OpenStack Jenkins <jenkins at openstack.org>:
> > See
> > https://jenkins.openstack.org/job/periodic-horizon-python27-stable-folsom/178/
> 
> ...snip...
> 
> 2013-03-28 06:04:01.567 | FAIL: test_get_default_role
> (horizon.tests.api_tests.keystone_tests.RoleAPITests)
> 2013-03-28 06:04:01.567 |
> ----------------------------------------------------------------------
> 2013-03-28 06:04:01.567 | Traceback (most recent call last):
> 2013-03-28 06:04:01.568 |   File
> "/home/jenkins/workspace/periodic-horizon-python27-stable-folsom/horizon/tests/api_tests/keystone_tests.py",
> line 76, in test_get_default_role
> 2013-03-28 06:04:01.568 |     keystoneclient =
> self.stub_keystoneclient()
> 2013-03-28 06:04:01.568 |   File
> "/home/jenkins/workspace/periodic-horizon-python27-stable-folsom/horizon/test.py",
> line 329, in stub_keystoneclient
> 2013-03-28 06:04:01.568 |     self.keystoneclient =
> self.mox.CreateMock(keystone_client.Client)
> 2013-03-28 06:04:01.568 |   File
> "/home/jenkins/workspace/periodic-horizon-python27-stable-folsom/.tox/py27/local/lib/python2.7/site-packages/mox.py",
> line 258, in CreateMock
> 2013-03-28 06:04:01.568 |     new_mock = MockObject(class_to_mock,
> attrs=attrs)
> 2013-03-28 06:04:01.568 |   File
> "/home/jenkins/workspace/periodic-horizon-python27-stable-folsom/.tox/py27/local/lib/python2.7/site-packages/mox.py",
> line 556, in __init__
> 2013-03-28 06:04:01.568 |     attr = getattr(class_to_mock, method)
> 2013-03-28 06:04:01.568 |   File
> "/home/jenkins/workspace/periodic-horizon-python27-stable-folsom/.tox/py27/local/lib/python2.7/site-packages/mox.py",
> line 608, in __getattr__
> 2013-03-28 06:04:01.568 |     raise UnknownMethodCallError(name)
> 2013-03-28 06:04:01.568 | UnknownMethodCallError: Method called is
> not
> a member of the object: Method called is not a member of the object:
> auth_token
> 2013-03-28 06:04:01.568 | >>  raise
> UnknownMethodCallError('auth_token')
> 
> ...snip...
> 
> 2013-03-28 06:04:03.188 | python-keystoneclient==0.2.3
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 



More information about the OpenStack-dev mailing list