[openstack-dev] pep8 pinning in requirements
Sean Dague
sdague at linux.vnet.ibm.com
Wed Mar 20 17:33:57 UTC 2013
On 03/20/2013 11:47 AM, Mac Innes, Kiall wrote:
> On 20/03/13 15:29, Chuck Short wrote:
>> Actually it does matter which version pep8 that the distros ship. Ubuntu
>> for example runs the full tests on each commit in our CI lab so if our
>> versions of pep8 are not in sync then we will have to carry an out of
>> tree patch or Openstack will get a wrong bug report.
>
> Honest question - Why does Ubuntu perform these?
Yes, I'm curious as well. I can understand re-running unit tests to make
sure that those still run, but I in no way understand running
hacking.py/pep8 outside of upstreaming code.
That's an acceptance criteria for git master, nothing more. Deciding to
run it on patched / packaged versions of OpenStack out of tree with
different pep8 just seems like generating more work for no benefit.
-Sean
--
Sean Dague
IBM Linux Technology Center
email: sdague at linux.vnet.ibm.com
alt-email: sldague at us.ibm.com
More information about the OpenStack-dev
mailing list