[openstack-dev] Build-time unit tests failing when building glance 2013.2.b1

Monty Taylor mordred at inaugust.com
Sun Jun 30 00:06:22 UTC 2013



On 06/29/2013 08:02 PM, John Bresnahan wrote:
>>
>> I believe we should fix the unittests to not shell out to glance-manage
>> in that manner. One of the nice things about moving the code from bin/
>> to glance.cmd is that it's available inside of the source tree for
>> unittests! :) What we want to do is call the glance.cmd.manage:main()
>> function directly. So, for instance, in:
>>
>> glance/tests/functional/__init__.py
>> and
>> glance/tests/functional/test_glance_manage.py
>>
>> We can call the function itself, rather than the shell wrapper.
> 
> That was the original intention and major motivation for the patch.
> However the configuration information is globally shared in the process
> space so pushing this through gave me pause.

The global config context is pissing me off enough that I might have to
break down and fix oslo.config too.

>> I'll make a patch. 
> 
> excellent!  thanks!

My pleasure!



More information about the OpenStack-dev mailing list