Open Stack

On Mon, Jun 17, 2013 at 5:01 PM, Joe Gordon <joe.gordon0 at gmail.com> wrote:

> Hi All,
>
> A patch to move the run_tests.sh script into oslo-incubator (
> https://review.openstack.org/#/c/32736/), has brought up the bigger
> question of what is the future of './run_tests.sh.'
>
> This seems like a topic that directly affects all developers, so it
> sounded like it should be brought to the Mailing list.
>
> Reasons to keep run_tests.sh:
>
> * there is no possibility to run tests with testtools instead of testr.
> This feature allows us to use the debugger.
> * in some projects tox doesn't use a testr wrapper to report progress
> while tests are running
> * building the sdist can be slow (slow == noticeable)
>
>
> Monty's Rant:
>
> "So, I'm SUPER torn on this.
>
> On the one hand, we use tox in the gate, and run_tests.sh hides that from
> people and then they get confused about why some change they made to
> run_tests.sh doesn't get reflected in the reality of the project.
>
> On the other hand, what Victor says is true. We need to land a couple of
> changes to upstream tox that would allow it to not run develop each time -
> but we seem to have a hard time doing that.
>
> On the third hand, we'd doing an INSANE amount of work to make working
> with testing in a venv "easy" and what we've wound up with is a situation
> where we have multiple competing incompatible ways of doing things.
>
> Here's what I do: source .tox/py27/bin/activate testr run --parallel testr
> run --parallel testr run some-test testr run --failing deactivate
>
> Sometimes, if I'm being fancy, I'll do: virtualenv foo foo/bin/pip install
> -r requirements.txt -r test-requirements.txt
>
> I believe vish just installs the depends directly on his box and skips
> venvs altogether.
>
> It turns out that testr is a powerful tool with a nice UI. Instead of
> putting wrappers around it, perhaps we should add support for our output
> stream thing we like to it upstream. We should also add support to it for
> dropping into a debugger directly, so that the testtools issue goes away.
> Then we should land a patch to upstream tox to get it to do setup.py
> develop instead of sdist+ install.
>
> If we did that, we could have "run tox" be the simple answer for anyone
> who just wants to run whatever the gate runs, because that will always
> work. And if they want to do fancier things, they should learn about venvs
> and testr.
>
> However, if we ARE going to keep a run_tests.sh file in our trees, we
> should certainly have a single copy and have it behave consistently.
>
> Please note that some projects actually do just have run_tests.sh as a
> thin wrapper around tox."
>
>
> What do you think? Should we keep run_tests as is and port to oslo, or
> should we revisit the role of run_tests.sh?
>
>
> best,
>
> Joe
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> As far as the question of whether run_tests.sh lives or dies, I have no
intention of killing it (or letting it die in Cinder).

With respect to porting it to OSLO, I'm torn a bit here.  There are some
things I like WRT the direction of testing in other projects, and some
things not so much.  The ability to have run_tests in the project allows me
to tweak things and keep it usable (granted this capability probably
wouldn't go away).

I'm just a bit uneasy with all of the testing "enhancements and
improvements".  We've been trying to pull said changes in to Cinder but to
be honest most of it from a dev perspective has been far more trouble than
it's been worth.  One change we loose ability to run individual tests, get
it back... loose ability to run debugger... get it back... loose color
output (I know horror or horrors), and so on.  Understood if it was common
or removed we'd all be in the same boat, but I'm not sure other care about
some things like no virtual env and debugging tests as much as I do.

Anyway, run_tests is extremely valuable to me and I believe others as is
the ability to run outside of venv etc.  Granted there is a ton of overlap
and OSLO does have meritt, I just don't want unwanted and unnecessary
change as we've finally got things stabilized again.

Thanks,
John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130617/5adaded9/attachment.html>