[openstack-dev] [Oslo] Code review I7ec346db: Improve usability when backdoor_port is nonzero

Eric Windisch eric at cloudscaling.com
Thu Jun 13 20:06:31 UTC 2013


On June 13, 2013 at 15:26:31 , Ray Pekowski (pekowski at gmail.com) wrote:
On Thu, Jun 13, 2013 at 12:49 PM, Eric Windisch <eric at cloudscaling.com> wrote:

For TCP, I prefer the port-0 approach, but there would need to be a way to determine which port the backdoor is listening on. I think having this represented in logs would be sufficient.

Would you give a +1 to a resubmit of the patch with the backdoor_port option deprecated and replaced it with a boolean option called enable_backdoor?  Or are you of the opinion that the current backdoor_port option is not broken?


I'm not sure I'd classify it as 'broken', but I think it is bad at present.
A boolean would be better. For determining the port, I'd rather it be random. More than that, as before stated, I'd prefer a unix socket.
To make this a unix socket, you'd have to create the socket yourself and then pass that to eventlet.backdoor.backdoor_server(), rather than using eventlet.backdoor.backdoor()

Regards,
Eric Windisch

Ray
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130613/f8a66c85/attachment.html>


More information about the OpenStack-dev mailing list