Open Stack

Hi all,

As part of trying to get https://review.openstack.org/#/c/28969 through the review process, I have hit an issue with rebasing.

The main issue appears to be that the function that all my code ran within (_get_image_metadata)  was removed in change 6b16c8731c44e4a6c80b803f3e8afdd88386d577.

I'm now trying to understand where the Metadata from an image is being collected and passed through as it seems that now the get_image_metadata call has gone, the appropriate place to put my code (which has now been heavily refactored from the latest changeset in the above link!) would be in the get_image function (api.py:528).

If get_image is indeed the correct place to put it, should this be renamed to something else to reflect that this is getting both volume and image data, or should I add a get_volume function with my code in it and then refactor the create and recreate functions to include this new function.

Thanks in advance for any thoughts,

Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130606/ba7d3255/attachment.html>