[openstack-dev] Opinions needed: Changing method signature in RPC callback ...

Sandy Walsh sandy.walsh at rackspace.com
Thu Jul 18 20:00:35 UTC 2013

On 07/18/2013 03:55 PM, Eric Windisch wrote:
> On Thu, Jul 18, 2013 at 10:09 AM, Sandy Walsh <sandy.walsh at rackspace.com
> <mailto:sandy.walsh at rackspace.com>> wrote:
>     My worry is busting all the other callbacks out there that use
>     olso-common.rpc
> These callback methods are part of the Kombu driver (and maybe part of
> Qpid), but are NOT part of the RPC abstraction. These are private
> methods. They can be broken for external consumers of these methods,
> because there shouldn't be any. It will be a good lesson to anyone that
> tries to abuse private methods.

I was wondering about that, but I assumed some parts of amqp.py were
used by other transports as well (and not just impl_kombu.py)

There are several callbacks in amqp.py that would be affected.

> -- 
> Regards,
> Eric Windisch
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

More information about the OpenStack-dev mailing list