[openstack-dev] HACKING and new-style relative imports

Joe Gordon joe.gordon0 at gmail.com
Tue Jul 9 14:55:07 UTC 2013

On Tue, Jul 9, 2013 at 1:28 PM, Kieran Spear <kispear at gmail.com> wrote:

> Hi all,
> There's a review up to make Horizon pass H304 (no relative imports):
> https://review.openstack.org/#/c/35664/
> Old-style relative imports are dangerous, but I can't think of a good
> enough reason to forbid new-style imports, e.g.:
> from .views import IndexView
> instead of
> from openstack_dashboard.dashboards.project.images_and_snapshots.views \
>       import IndexView
> particularly in Horizon where nesting is deep and you otherwise end up
> with many imports that won't fit into 80 characters. I think if we're going
> to make the change above the benefits would need to outweigh the effect on
> readability.
> There's some discussion on the review already, but I'd like to hear from a
> more general audience. Thoughts?


"Do not use relative names in imports. Even if the module is in the same
package, use the full package name. This helps prevent unintentionally
importing a package twice."

> Cheers,
> Kieran
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130709/390855fa/attachment.html>

More information about the OpenStack-dev mailing list