[openstack-dev] [neutron] Renaming and code reviews...

Paul Michali pcm at cisco.com
Mon Jul 8 19:54:13 UTC 2013

Many people are converting their code, which is out for review, to neutron. One thing I'm seeing is the files which have been moved and renamed, are showing up as new files (not to pick on it, but as an example  https://review.openstack.org/#/c/33297/10/neutron/tests/unit/ml2/test_type_gre.py) so it is hard to tell if there are other changes going on.

Should submitters ensure that the change set only has renaming changes (and maybe include a note in the patch set saying so), or is there a way that multiple patch sets can be used to make that clear (like one to rename in the text of the file, and a second one to move the file to a new location)?

Just wondering if there is a way to make reviewing easier…

PCM (Paul Michali)

MAIL pcm at cisco.com
IRC   pcm_  (irc.freenode.net)
TW   @pmichali

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130708/f2d7eeb7/attachment.html>

More information about the OpenStack-dev mailing list