[openstack-dev] "if X not in Y" vs. "if not X in Y" consensus?

Flavio Percoco fpercoco at redhat.com
Thu Jan 31 09:26:10 UTC 2013


On 01/31/2013 06:36 AM, Zhongyue Luo wrote:
>
> What I'm suggesting is that we should add an entry in HACKING.rst
> stating we should use "if X not in Y" and prevent mix use of the two.
>
> Would there be any reason why we shouldn't do this? such as it adds more
> burden to reviewers, or because we should have the freedom to choose
> whatever we want to use?

+1

Big fan of consistency as well and I think this should be part of OS 
coding standards.


-- 
{ name: "Flavio Percoco",
   gpg: "87112EC1",
   internal: "8261386",
   phone: "+390687502386",
   irc: ["fpercoco", "flaper87"]}



More information about the OpenStack-dev mailing list