Open Stack

On Mon, Jan 21, 2013 at 1:32 PM, Eric Windisch <eric at cloudscaling.com>wrote:

> -1; The tests need to come out of common since these tests are used by the
> zeromq tests, which will break. Otherwise, it looks fairly reasonable at a
> glance, although I would like to evaluate it a bit further. As others
> indicated, there might be ways to improve backwards compat.
>
The tests I added in common.py are in a class called BaseRpcAMQPTestCase
(which I did not create, just added to).  That class only gets executed if
one of the test_* files inherits from that class.  The only test file that
does that right now is test_kombu.py.  The tests are meant to be for any
AMQP based implementation, but comments in the Qpid tests indicate that it
is not possible to run Qpid in loopback mode and therefore Qpid doesn't get
to take advantage of the common AMQP tests.  Someday it may.  Someday there
may be another AMQP implementation.  The point is my tests are common to
any AMQP implementation so belong in some common file.  If you think I
should create a common_amqp.py file, I will.

This got me thinking.  The multithreaded_resp_routing test is truly
common.  I should put it into the overall common BaseRpcTestCase class.
And I will, but let me know about whether you think I should also create a
common_amqp.py file.

As an aside, we're already using some similar patterns in the zeromq
> driver. There might be further room for reuse here, but as I said, I'll
> review the patch in more depth when I'm back at a keyboard.
>
Thanks,
Ray
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130121/3357e80d/attachment.html>